[stable33] fix(files_sharing): Use share id in file actions - #62402
Open
backportbot[bot] wants to merge 1 commit into
Open
[stable33] fix(files_sharing): Use share id in file actions#62402backportbot[bot] wants to merge 1 commit into
backportbot[bot] wants to merge 1 commit into
Conversation
backportbot
Bot
requested review from
CarlSchwan,
benjaminfrueh and
provokateurin
July 22, 2026 11:19
provokateurin
force-pushed
the
backport/61099/stable33
branch
from
July 22, 2026 11:27
d8eeccf to
293690b
Compare
provokateurin
marked this pull request as ready for review
July 22, 2026 11:27
provokateurin
requested review from
kristian-zendato,
nfebe and
sorbaugh
and removed request for
a team
July 22, 2026 11:27
provokateurin
approved these changes
Jul 22, 2026
provokateurin
enabled auto-merge
July 22, 2026 11:27
CarlSchwan
approved these changes
Jul 22, 2026
nickvergessen
requested changes
Jul 22, 2026
| const node = nodes[0] | ||
| const url = generateOcsUrl('apps/files_sharing/api/v1/deletedshares/{id}', { | ||
| id: node.id, | ||
| id: node.attributes['share-id'], |
Member
There was a problem hiding this comment.
At least on API level it seems to expect provider:id and id needs to be the group share ID and not the user-group share ID, e.g.
Contributor
There was a problem hiding this comment.
I checked what share-id resolves to here. It comes from ocsEntry.id, which for deleted shares is DeletedShareAPIController's $share->getFullId(), so it is already provider:id. For group shares resolveGroupShares() keeps the parent group share, so getFullId() returns the group id. So the action already sends provider:groupShareId
enjeck
force-pushed
the
backport/61099/stable33
branch
from
August 5, 2026 04:32
293690b to
cc6c76b
Compare
Signed-off-by: provokateurin <kate@provokateurin.de>
icewind1991
force-pushed
the
backport/61099/stable33
branch
from
August 5, 2026 10:55
cc6c76b to
5a004e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #61099
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.