Refactor/oauth2 api controller#60487
Open
icarta-l wants to merge 1 commit into
Open
Conversation
icarta-l
requested review from
Altahrim,
artonge,
come-nc and
icewind1991
and removed request for
a team
Write GetOauth2TokenController.md, GetOauth2TokerFeature.md, Oauth2Domain and readme.md files to present a new architecture of the token retrieval feature. Files can be found under a new "diagrams" folder inside the oauth2/lib repository. Signed-off-by: Idan <cartaidan@gmail.com>
icarta-l
force-pushed
the
refactor/oauth2-api-controller
branch
from
290f0d6 to
fbcaa3b
Compare
Author
|
I have moved the interface for the repositories and other dependencies passed to the Use Case in the GetOauth2TokenInternals/GetOauth2TokenUseCase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request aims at discussing the redesign of the architecture of the nextcloud/server repository. It follows the Clean Architecture principles by Robert C. Martin and the hybrid packaged by components and features approach.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)