Skip to content

fix(files_sharing): validate input in PublicPreviewController#getPreview #59253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mvanhorn wants to merge 2 commits into
base: master
Choose a base branch
from
+13 −8
Open

fix(files_sharing): validate input in PublicPreviewController#getPreview #59253

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed3156e
fix(files_sharing): validate input in PublicPreviewController#getPreview
mvanhorn Mar 27, 2026
310d3cc
chore(sharing): update docblock for PublicPreviewController::getPreview
joshtrichards Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions apps/files_sharing/lib/Controller/PublicPreviewController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,14 @@ protected function isPasswordProtected(): bool {
return $this->share->getPassword() !== null;
}


/**
* Get a preview for a shared file
* Get a preview for a public share.
*
* For shares pointing to a single file, the $file parameter is ignored and may be empty.
* For folder shares, $file must be the relative path to a file inside the shared folder.
*
* @param string $token Token of the share
* @param string $file File in the share
* @param string $file Relative path to a file inside a shared folder; ignored for single-file shares
* @param int $x Width of the preview
* @param int $y Height of the preview
* @param bool $a Whether to not crop the preview
Expand Down Expand Up @@ -122,19 +124,22 @@ public function getPreview(
try {
$node = $share->getNode();
if ($node instanceof Folder) {
$file = $node->get($file);
if ($file === '') {
return new DataResponse([], Http::STATUS_BAD_REQUEST);
}
$fileNode = $node->get($file);
} else {
$file = $node;
$fileNode = $node;
}

$f = $this->previewManager->getPreview($file, $x, $y, !$a);
$f = $this->previewManager->getPreview($fileNode, $x, $y, !$a);
$response = new FileDisplayResponse($f, Http::STATUS_OK, ['Content-Type' => $f->getMimeType()]);
$response->cacheFor($cacheForSeconds);
return $response;
} catch (NotFoundException $e) {
// If we have no preview enabled, we can redirect to the mime icon if any
if ($mimeFallback) {
if ($url = $this->mimeIconProvider->getMimeIconUrl($file->getMimeType())) {
if ($mimeFallback && isset($fileNode) && !($fileNode instanceof Folder)) {
if ($url = $this->mimeIconProvider->getMimeIconUrl($fileNode->getMimeType())) {
return new RedirectResponse($url);
}
}
Expand Down