fix(CapabilitiesManager): only log execution time if debug mode is enabled#58971
Open
fix(CapabilitiesManager): only log execution time if debug mode is enabled#58971
Conversation
szaimen
force-pushed
the
enh/noid/slow-caps-debug-mode
branch
from
e31f263 to
76b8024
Compare
szaimen
changed the title
szaimen
force-pushed
the
enh/noid/slow-caps-debug-mode
branch
3 times, most recently
from
6755cc9 to
d284eaa
Compare
…enabled Signed-off-by: Simon L. <szaimen@e.mail.de>
szaimen
force-pushed
the
enh/noid/slow-caps-debug-mode
branch
from
d284eaa to
89aa1ed
Compare
szaimen
added
3. to review
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
/backport to stable32 |
szaimen
requested review from
ArtificialOwl,
CarlSchwan,
come-nc,
icewind1991,
miaulalala and
salmart-dev
and removed request for
a team
szaimen
changed the title
Contributor
|
The point of the log line was for users to report the bug to the application developers I believe. Is it happening a lot? |
Contributor
Author
Unfortunately if the system is under high load, this reporting feature leads to a lot of false-positives if the response time increases due to the high load. So I would rather only enable it in debug mode. Added the reasoning to the PR description. |
miaulalala
requested changes
Mar 17, 2026
Comment on lines
+67
to
+69
| if ($debugMode) { | ||
| $timeSpent = $endTime - $startTime; | ||
| if ($timeSpent > self::ACCEPTABLE_LOADING_TIME) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if ($debugMode) { | |
| $timeSpent = $endTime - $startTime; | |
| if ($timeSpent > self::ACCEPTABLE_LOADING_TIME) { | |
| $timeSpent = $endTime - $startTime; | |
| if ($debugMode && $timeSpent > self::ACCEPTABLE_LOADING_TIME) { |
Contributor
There was a problem hiding this comment.
maths is cheap, makes the code more readable too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.