fix: don't rely on share providers being avaiable in CleanupShareTarget #57926
+36
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
artonge,
come-nc,
salmart-dev and
sorbaugh
and removed request for
a team
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
share-target-repair-no-providers
branch
from
3bcdd21 to
a238620
Compare
artonge
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During maintenance, apps are not enabled, so the share providers from them aren't there.
This manually edits the DB instead and removes the need to construct
IShareinstances.