Skip to content

fix(files_sharing): rate limit share creation 40 times per 10 minutes#57666

Open
biredel wants to merge 2 commits intonextcloud:masterfrom
biredel:rate-limit-share-creation
Open

fix(files_sharing): rate limit share creation 40 times per 10 minutes#57666
biredel wants to merge 2 commits intonextcloud:masterfrom
biredel:rate-limit-share-creation

Conversation

@biredel
Copy link

@biredel biredel commented Jan 20, 2026

Share creation was unlimited before #50905 setting to 20/600s. That proved to be too low for (integration tests, and more crucially) some legitimate human actions, e.g. chat messages with attachments in Talk.

Checklist

  • What is partially reverted here was already manually exempt from testing
  • No font-end changes
  • Documentation update not required
  • Backports requested where applicable (ex: critical bugfixes)
  • Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
  • Milestone added for target branch/version (ex: 32.x for stable32)

@biredel biredel requested a review from a team as a code owner January 20, 2026 16:41
@biredel biredel requested review from Altahrim, ArtificialOwl, icewind1991 and leftybournes and removed request for a team January 20, 2026 16:41
@susnux susnux requested a review from nickvergessen January 20, 2026 17:21
@susnux susnux added this to the Nextcloud 33 milestone Jan 20, 2026
@biredel biredel changed the title fix(files_sharing): rate limit share creation 200 times per 10 minutes fix(files_sharing): rate limit share creation 40 times per 10 minutes Jan 23, 2026
@biredel biredel requested a review from nickvergessen January 26, 2026 14:09
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Was unlimited before nextcloud#50905 setting to 20/600s which proved to be too low for some legitimate human actions, e.g. chat messages with attachments in Talk. Fix that by bumping to some arbitrary higher value, until some clearer justification for having it lower or higher is determined.

Signed-off-by: biredel <67849440+biredel@users.noreply.github.com>
no goal stated; just copied from review comment

Signed-off-by: biredel <67849440+biredel@users.noreply.github.com>
@biredel biredel force-pushed the rate-limit-share-creation branch from f4631ec to 806a28d Compare February 9, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Default share creation rate limit breaks typical human usage, e.g. in 429 in Talk app

3 participants