fix(background-jobs): Fix unit tests with 32-bits #57099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
requested review from
Altahrim,
come-nc,
salmart-dev,
susnux and
yemkareems
and removed request for
a team
susnux
force-pushed
the
carl/fix-32-bits-job-tests
branch
from
5488355 to
b2516a6
Compare
come-nc
reviewed
Dec 15, 2025
Comment on lines
+36
to
+37
| - '**/lib/**' | ||
| - '**.php' |
Contributor
There was a problem hiding this comment.
If the filter is that broad the scheduled run should be removed.
Contributor
There was a problem hiding this comment.
Its a reduced version of the phpunit-DBTYPE so its even less broad. And even the schedule is less frequent than the DB and no DB workflows.
| runs-on: ubuntu-latest | ||
|
|
||
| if: ${{ github.repository_owner != 'nextcloud-gmbh' }} | ||
| needs: changes |
Member
There was a problem hiding this comment.
this breaks the schedule?
CarlSchwan
force-pushed
the
carl/fix-32-bits-job-tests
branch
from
b2516a6 to
f8cf78f
Compare
CarlSchwan
requested review from
ChristophWurst,
SebastianKrupinski and
tcitworld
as code owners
CarlSchwan
force-pushed
the
carl/fix-32-bits-job-tests
branch
from
3eb92d1 to
a76f00b
Compare
CarlSchwan
changed the title
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
CarlSchwan
force-pushed
the
carl/fix-32-bits-job-tests
branch
from
a76f00b to
1c45cb2
Compare
SebastianKrupinski
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
3. to review, feature component)stable32)