Skip to content

fix: handle UniqueConstraintViolationException gracefully #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
st3iny merged 1 commit into from
Jan 31, 2026
Merged

fix: handle UniqueConstraintViolationException gracefully #605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/Command/Generate.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,12 @@

namespace OCA\PreviewGenerator\Command;

use OC\DB\Exceptions\DbalException;
use OCA\Files_External\Service\GlobalStoragesService;
use OCA\PreviewGenerator\Model\WorkerConfig;
use OCA\PreviewGenerator\Service\ModuloService;
use OCA\PreviewGenerator\SizeHelper;
use OCP\DB\Exception;
use OCP\Encryption\IManager;
use OCP\Files\File;
use OCP\Files\Folder;
Expand Down Expand Up @@ -309,6 +311,13 @@ private function parseFile(File $file): void {
$class = $e::class;
$error = $e->getMessage();
$this->output->writeln("<error>{$class}: {$error}</error>");
} catch (DbalException $e) {
// Since the introduction of the oc_previews table, preview duplication caused by
// duplicated specifications will cause a UniqueConstraintViolationException. We can
// simply ignore this exception here and carry on.
if ($e->getReason() !== Exception::REASON_UNIQUE_CONSTRAINT_VIOLATION) {
throw $e;
}
}
}

Expand Down
9 changes: 9 additions & 0 deletions lib/Command/PreGenerate.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,12 @@

namespace OCA\PreviewGenerator\Command;

use OC\DB\Exceptions\DbalException;
use OCA\PreviewGenerator\Service\NoMediaService;
use OCA\PreviewGenerator\SizeHelper;
use OCP\AppFramework\Db\TTransactional;
use OCP\AppFramework\Utility\ITimeFactory;
use OCP\DB\Exception;
use OCP\Encryption\IManager;
use OCP\Files\File;
use OCP\Files\GenericFileException;
Expand Down Expand Up @@ -197,6 +199,13 @@ private function processFile(File $file): void {
$class = $e::class;
$error = $e->getMessage();
$this->output->writeln("<error>{$class}: {$error}</error>");
} catch (DbalException $e) {
// Since the introduction of the oc_previews table, preview duplication caused by
// duplicated specifications will cause a UniqueConstraintViolationException. We can
// simply ignore this exception here and carry on.
if ($e->getReason() !== Exception::REASON_UNIQUE_CONSTRAINT_VIOLATION) {
throw $e;
}
}
}
}
Expand Down
Loading