Skip to content

Use filled favorite icons and remove document icons #1730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aronovgj wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −9
Open

Use filled favorite icons and remove document icons #1730

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions src/components/NoteItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,11 @@
:size="20"
fill-color="#E9322D"
/>
<StarOutlineIcon v-else-if="note.favorite"
<StarIcon v-else-if="note.favorite"
slot="icon"
:size="20"
fill-color="#FC0"
/>
<FileDocumentOutlineIcon v-else
slot="icon"
:size="20"
/>
</template>
<template v-if="isShared" #indicator>
<ShareVariantOutlineIcon :size="16" fill-color="#0082c9" />
Expand Down Expand Up @@ -107,10 +103,9 @@ import NcActionButton from '@nextcloud/vue/components/NcActionButton'
import NcActionSeparator from '@nextcloud/vue/components/NcActionSeparator'
import NcActionInput from '@nextcloud/vue/components/NcActionInput'
import AlertOctagonOutlineIcon from 'vue-material-design-icons/AlertOctagonOutline.vue'
import FileDocumentOutlineIcon from 'vue-material-design-icons/FileDocumentOutline.vue'
import FolderOutlineIcon from 'vue-material-design-icons/FolderOutline.vue'
import PencilOutlineIcon from 'vue-material-design-icons/PencilOutline.vue'
import StarOutlineIcon from 'vue-material-design-icons/StarOutline.vue'
import StarIcon from 'vue-material-design-icons/Star.vue'
import { categoryLabel, routeIsNewNote } from '../Util.js'
import { showError } from '@nextcloud/dialogs'
import { setFavorite, setTitle, fetchNote, deleteNote, setCategory } from '../NotesService.js'
Expand All @@ -122,11 +117,10 @@ export default {

components: {
AlertOctagonOutlineIcon,
FileDocumentOutlineIcon,
FolderOutlineIcon,
NcActionButton,
NcListItem,
StarOutlineIcon,
StarIcon,
NcActionSeparator,
NcActionInput,
PencilOutlineIcon,
Expand All @@ -145,6 +139,7 @@ export default {
loading: {
note: false,
category: false,
favorite: false,
},
newTitle: '',
renaming: false,
Expand Down
Loading