fix: restore search, directions, and settings interactions#1627
Open
DeBaschdi wants to merge 3 commits into
Open
fix: restore search, directions, and settings interactions#1627DeBaschdi wants to merge 3 commits into
DeBaschdi wants to merge 3 commits into
Conversation
Signed-off-by: Bastian Kleinschmidt <debaschdi@googlemail.com>
Signed-off-by: Bastian Kleinschmidt <debaschdi@googlemail.com>
Signed-off-by: Bastian Kleinschmidt <debaschdi@googlemail.com>
DeBaschdi
force-pushed
the
fix/1614-search-directions-settings
branch
from
July 15, 2026 05:40
9507509 to
27437b4
Compare
Member
|
Very very cool!! Did some smoke testing and some minor interface issues came up. Let me know if that's at all related here or separate. :) Mostly missing icons: Missing icons in nav, menus and "Clear POIs" button
Missing icons for further overlay switcher and location toggle
Missing icons for favorite sidebar
Missing icon on favorite marker on mapIt's there in the left nav though. A local review with Claude Opus 4.8 pointed out these things:
Note that it would be good to add this info to the commits as per the contribution guidelines. Just a simple line with the proper trailer which lists the tool and model+version is enough :) |
Member
|
Oh and while we're at it, you could also set the max-version to 36 or so? :) |
Author
|
I'll take another look to see what might be wrong with the icons. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Summary
Validation
AI (if applicable)
Fixes #1596
Fixes #1614