Skip to content

fix: restore search, directions, and settings interactions#1627

Open
DeBaschdi wants to merge 3 commits into
nextcloud:masterfrom
DeBaschdi:fix/1614-search-directions-settings
Open

fix: restore search, directions, and settings interactions#1627
DeBaschdi wants to merge 3 commits into
nextcloud:masterfrom
DeBaschdi:fix/1614-search-directions-settings

Conversation

@DeBaschdi

@DeBaschdi DeBaschdi commented Jul 15, 2026

Copy link
Copy Markdown

Summary

  • restore Vue 3 component bindings used by search, directions, settings, favorites, and navigation
  • prevent invalid My Maps IDs and the accidental /m/noIcon request
  • allow PageController construction without a user ID while keeping authenticated actions guarded

Validation

  • production Webpack build
  • Psalm static analysis
  • targeted ESLint and PHP syntax checks
  • PHPUnit: 4 tests, 8 assertions
  • LF and git diff --check verification

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Fixes #1596
Fixes #1614

Signed-off-by: Bastian Kleinschmidt <debaschdi@googlemail.com>
Signed-off-by: Bastian Kleinschmidt <debaschdi@googlemail.com>
Signed-off-by: Bastian Kleinschmidt <debaschdi@googlemail.com>
@DeBaschdi
DeBaschdi force-pushed the fix/1614-search-directions-settings branch from 9507509 to 27437b4 Compare July 15, 2026 05:40
@DeBaschdi DeBaschdi changed the title Fix/1614/1596 search directions settings fix: restore search, directions, and settings interactions Jul 15, 2026
@jancborchardt

Copy link
Copy Markdown
Member

Very very cool!!

Did some smoke testing and some minor interface issues came up. Let me know if that's at all related here or separate. :) Mostly missing icons:

Missing icons in nav, menus and "Clear POIs" button

Screenshot From 2026-07-15 17-56-58

Missing icons for further overlay switcher and location toggle

Screenshot From 2026-07-15 17-57-05

Missing icons for favorite sidebar

Screenshot From 2026-07-15 17-59-52

Missing icon on favorite marker on map

It's there in the left nav though.
Screenshot From 2026-07-15 18-00-25


A local review with Claude Opus 4.8 pointed out these things:

  1. Incomplete migration — src/components/map/PlaceContactPopup.vue:22 still uses old inputLabel="FN" on an NcSelect. Functionally works (uses v-model), but inputLabel is now dead → contact multiselect loses accessible label. Same bug class as this PR; worth folding in. (Also same file line 23 in the "add contact address" flow.)
  2. Behavior change — SearchField.onOptionSelected now sets this.mySelectedOption = option unconditionally, including for type === 'query' options (before: only on the non-query branch). After firing an OSM text search the field's selected-option now shows the raw query string.

The content of this PR was partly or fully generated using AI

Note that it would be good to add this info to the commits as per the contribution guidelines. Just a simple line with the proper trailer which lists the tool and model+version is enough :)
https://github.com/nextcloud/.github/blob/master/CONTRIBUTING.md#ai-assisted-contributions

@jancborchardt

Copy link
Copy Markdown
Member

Oh and while we're at it, you could also set the max-version to 36 or so? :)

@DeBaschdi

Copy link
Copy Markdown
Author

I'll take another look to see what might be wrong with the icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: search, directions and settings do nothing [Bug]: Maps settings do not work

2 participants