fix no sent mailbox configured by hamza221 · Pull Request #8311 · nextcloud/mail

hamza221 · 2023-03-28T23:04:22Z

Fix #4153
Repro:

remove the default folder for sent ("you can do it in vuex by setting sentMailboxId to null")
Try to send a message

Fix:
Ps: Other ideas are appreciated

Check if a mailbox named Sent or equivalent in the local language

if it exists set it as Sent default folder and resend message, if not:

create a new mailbox
set it as send default folder
resend the message
Catch exceptions and inform the user with toasts accordingly

src/components/Composer.vue

src/components/NewMessageModal.vue

JohannesGGE · 2023-07-07T09:40:10Z

Where exactly do you set sentMailboxId to null? (I can't get the error reproduced)

hamza221 · 2023-07-19T16:06:14Z

Where exactly do you set sentMailboxId to null? (I can't get the error reproduced)

I do it in the vue.js devtools browser extension

ChristophWurst

The changes feel a bit too complex and messy. I think we should try to find a cleaner, less complicated spot to place the logic. I'll think about an alternative.

src/components/Composer.vue

src/components/NewMessageModal.vue

ChristophWurst · 2023-09-13T09:40:38Z

The changes feel a bit too complex and messy. I think we should try to find a cleaner, less complicated spot to place the logic. I'll think about an alternative.

How about we just move the logic into the head of NewMessageModal::onSend? We have access to the accountId and can fetch the account, check for the mailbox existence and act, then proceed with the usual send logic.

The good news is that this isn't too far off the current state. The code just has to be pushed around a bit.

I also think we don't necessarily need a special loading text for this state. For the user it's sufficient if we show Sending … while creating/assigning the mailbox

ChristophWurst

The logical flow looks good otherwise

src/components/NewMessageModal.vue

Signed-off-by: hamza221 <hamzamahjoubi221@gmail.com>

ChristophWurst

No test coverage

lib/Controller/MailboxesController.php

appinfo/routes.php

Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>

lib/Controller/MailboxesController.php

Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>

lib/Contracts/IMailManager.php

Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>

ChristophWurst · 2025-05-16T11:33:23Z

Works, but not as expected.

I see this chain of toasts, so the logic kicks in.

But my sent mailbox is now set to nullSent. Which is not just a UI glitch, it created this mailbox:

The creation shouldn't even happen, because I do have a mailbox named Sent and it does have the \sent attribute:

src/components/NewMessageModal.vue

Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>

ChristophWurst · 2025-05-27T07:55:53Z

It fails to detect my existing mailbox Sent and runs into a HTTP400. The toasts are honestly overwhelming and confusing.

First I get this

The message is sent and stored in my mailbox called "Sent", nevertheless?!

Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>

hamza221 · 2025-06-05T11:14:26Z

It fails to detect my existing mailbox Sent and runs into a HTTP400. The toasts are honestly overwhelming and confusing.

First I get this

The message is sent and stored in my mailbox called "Sent", nevertheless?!

Toasts were all over the place,
It should make sense now, I added early returns and removed extra Toasts

ChristophWurst · 2025-08-05T07:46:16Z

lib/Contracts/IMailManager.php

 	/**
 	 * @param Account $account
 	 * @param string $name
+	 * @param array<Horde_Imap_Client::SPECIAL_USE_*> $specialUseAttributes


^ see Psalm. Missing an import

ChristophWurst · 2025-08-05T07:47:59Z

src/components/NewMessageModal.vue

+			logger.info(`creating ${t('mail', 'Sent')} mailbox`)
+			try {
+				const newSentMailbox = await this.mainStore.createMailbox({ account, name: (account.personalNamespace ?? '') + t('mail', 'Sent'), specialUseAttributes: ['\\Sent'] })


nit: extract new mailbox name into a variable for code readability and to have the actual mailbox name logged, not just the translation

ChristophWurst · 2026-02-25T16:24:45Z

src/components/NewMessageModal.vue

+				try {
+					await this.setSentMailboxAndResend(account, sentMailboxId, data)
+					showSuccess(t('mail', 'Default sent folder set'))
+					this.onSend(data)


Missing await

ChristophWurst · 2026-02-25T16:25:35Z

src/components/NewMessageModal.vue

+
+			try {
+				await this.setSentMailboxAndResend(account, newSentMailboxId, data)
+				this.onSend(data)


missing await

ChristophWurst · 2026-02-25T16:25:57Z

src/components/NewMessageModal.vue

 		async onSend(data, force = false) {
+			const account = this.mainStore.getAccount(data.accountId)
+			if (!account?.sentMailboxId) {
+				this.onNewSentMailbox(data, account)


missing await

ChristophWurst · 2026-02-25T16:26:32Z

src/components/NewMessageModal.vue

+			const sentMailboxId = mailboxes.find((mailbox) => (mailbox.name === (account.personalNamespace ?? '') + 'Sent') || (mailbox.name === (account.personalNamespace ?? '') + t('mail', 'Sent')))?.databaseId
+			if (sentMailboxId) {
+				try {
+					await this.setSentMailboxAndResend(account, sentMailboxId, data)


the method takes to params. data is superfluous

ChristophWurst · 2026-02-25T16:28:07Z

src/components/NewMessageModal.vue

+			}
+			logger.info(`creating ${t('mail', 'Sent')} mailbox`)
+			try {
+				const newSentMailbox = await this.mainStore.createMailbox({ account, name: (account.personalNamespace ?? '') + t('mail', 'Sent'), specialUseAttributes: ['\\Sent'] })


createMailbox prepends the namespace too. This can lead to double namespacing.

kesselb · 2026-02-25T17:56:26Z

The changes for the backend, to create a mailbox with special usage, are in since #11889.

What do you think of implementing everything in the backend, like for the drafts? If there's no sent mailbox, we will just create one in transmission service. I think that makes everything a bit simpler.

hamza221 · 2026-03-12T14:47:46Z

Fix #4153

I created a draft here #12555 , way simpler as you assumed but I'm not sure how to test it yet

hamza221 self-assigned this Mar 28, 2023

hamza221 added bug 3. to review labels Mar 28, 2023

ChristophWurst reviewed Mar 30, 2023

View reviewed changes

src/components/Composer.vue Outdated Show resolved Hide resolved

ChristophWurst reviewed May 8, 2023

View reviewed changes

src/components/NewMessageModal.vue Outdated Show resolved Hide resolved

hamza221 requested a review from ChristophWurst June 18, 2023 16:20

hamza221 requested review from GretaD, JohannesGGE and st3iny June 26, 2023 14:40

ChristophWurst reviewed Sep 12, 2023

View reviewed changes

src/components/Composer.vue Outdated Show resolved Hide resolved

src/components/Composer.vue Show resolved Hide resolved

src/components/NewMessageModal.vue Outdated Show resolved Hide resolved

ChristophWurst mentioned this pull request Nov 29, 2023

Christoph's advent of code #9105

Closed

24 tasks

hamza221 marked this pull request as draft March 4, 2025 14:00

hamza221 added 2. developing and removed 3. to review labels Mar 7, 2025

hamza221 force-pushed the bug/not-sent-mailbox branch 2 times, most recently from 3913ba7 to 40f8232 Compare March 7, 2025 16:37

hamza221 requested a review from ChristophWurst March 7, 2025 16:38

hamza221 added 3. to review and removed 2. developing labels Mar 7, 2025

hamza221 marked this pull request as ready for review March 7, 2025 16:38

hamza221 requested a review from kesselb as a code owner March 7, 2025 16:38

ChristophWurst reviewed Mar 7, 2025

View reviewed changes

src/components/NewMessageModal.vue Outdated Show resolved Hide resolved

src/components/NewMessageModal.vue Outdated Show resolved Hide resolved

src/components/NewMessageModal.vue Outdated Show resolved Hide resolved

hamza221 force-pushed the bug/not-sent-mailbox branch from 3201810 to 89aaf43 Compare March 16, 2025 18:39

fix: no sent mailbox configured

3503feb

Signed-off-by: hamza221 <hamzamahjoubi221@gmail.com>

hamza221 force-pushed the bug/not-sent-mailbox branch from 89aaf43 to 3503feb Compare March 16, 2025 18:40

ChristophWurst requested changes Mar 17, 2025

View reviewed changes

lib/Controller/MailboxesController.php Outdated Show resolved Hide resolved

appinfo/routes.php Outdated Show resolved Hide resolved

fixup! fix: no sent mailbox configured

3f66fea

Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>

hamza221 marked this pull request as ready for review March 17, 2025 15:38

hamza221 added 3. to review and removed 2. developing labels Mar 17, 2025

hamza221 mentioned this pull request Mar 17, 2025

Configure special use mailbox when not set #10900

Open

ChristophWurst reviewed Mar 17, 2025

View reviewed changes

lib/Controller/MailboxesController.php Show resolved Hide resolved

fixup! fix: no sent mailbox configured

79f9ef3

Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>

hamza221 marked this pull request as draft March 17, 2025 18:16

fixup! fix: no sent mailbox configured

ee751f7

Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>

hamza221 marked this pull request as ready for review March 17, 2025 18:19

ChristophWurst reviewed Mar 17, 2025

View reviewed changes

lib/Contracts/IMailManager.php Outdated Show resolved Hide resolved

hamza221 and others added 2 commits April 3, 2025 12:44

fixup! fix: no sent mailbox configured

d56d453

Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>

Merge remote-tracking branch 'origin/main' into bug/not-sent-mailbox

2ac98f8

ChristophWurst reviewed May 16, 2025

View reviewed changes

src/components/NewMessageModal.vue Outdated Show resolved Hide resolved

fixup! fix: no sent mailbox configured

a9cbe36

Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>

hamza221 requested a review from ChristophWurst May 24, 2025 16:25

hamza221 added 2. developing and removed 3. to review labels Jun 5, 2025

hamza221 added 2 commits June 5, 2025 12:43

Merge remote-tracking branch 'origin/main' into bug/not-sent-mailbox

047169b

fixup! fix: no sent mailbox configured

5a3ab61

Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>

hamza221 added 3. to review and removed 2. developing labels Jun 5, 2025

ChristophWurst reviewed Aug 5, 2025

View reviewed changes

ChristophWurst reviewed Feb 25, 2026

View reviewed changes

hamza221 added 2. developing and removed 3. to review labels Mar 12, 2026

Conversation

hamza221 commented Mar 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JohannesGGE commented Jul 7, 2023

Uh oh!

hamza221 commented Jul 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ChristophWurst left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ChristophWurst commented Sep 13, 2023

Uh oh!

ChristophWurst left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ChristophWurst left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ChristophWurst commented May 16, 2025

Uh oh!

Uh oh!

ChristophWurst commented May 27, 2025

Uh oh!

hamza221 commented Jun 5, 2025

Uh oh!

ChristophWurst Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

ChristophWurst Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

ChristophWurst Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

ChristophWurst Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

ChristophWurst Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

ChristophWurst Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

ChristophWurst Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

kesselb commented Feb 25, 2026

Uh oh!

hamza221 commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hamza221 commented Mar 28, 2023 •

edited

Loading

hamza221 commented Jul 19, 2023 •

edited

Loading

hamza221 commented Mar 12, 2026 •

edited

Loading