feat: mailbox icon in thread view - #13486
Open
madbob wants to merge 1 commit into
Open
Conversation
madbob
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
August 13, 2026 18:09
Member
|
Thanks for looking into this! Would appreciate input from https://nextcloud-vue-components.netlify.app/#/Components/NcChip. Maybe a NcChip? https://nextcloud-vue-components.netlify.app/#/Components/NcChip |
Collaborator
Author
Signed-off-by: Roberto Guido <info@madbob.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

A proposal for #9535: in the thread view, I've added the icon of the parent mailbox for each message (and a tooltip with the full name of the mailbox itself).
Evaluating this feature, I've been concerned of adding the full name of the mailbox as it would eventually squeezes even more the envelope's header (especially on mobile). An icon is mostly decorative, slightly informative, and the tooltip provides the full information in unobtrusive way (in particular for non-special mailboxes not having their own recognizable icon).
Here I've also fixed a minor alignment issue with the sender line and message's preview line, and I've removed the
mailboxIdparameter forThreadEnvelope(I've not really understood his utility, as the same information is carried byenvelopeand indeed themailboxIdbinded to the local route inThreadimpacts in the functionalities enabled for every child envelope).Fixes #9535