refactor(php): replace strpos and switch with modern idioms#13125
Open
ChristophWurst wants to merge 1 commit into
Open
refactor(php): replace strpos and switch with modern idioms#13125ChristophWurst wants to merge 1 commit into
ChristophWurst wants to merge 1 commit into
Conversation
- Replace mb_strpos() !== false with str_contains() in GroupsIntegration (email addresses are ASCII so the multibyte variant is unnecessary) - Convert switch on FlagExpression operator to match in MessageMapper - Convert switch on IMAP error code to nested match in CouldNotConnectException Assisted-by: ClaudeCode:claude-sonnet-4-6 Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted-by: ClaudeCode:claude-sonnet-4-6
Ref #13077
🤖 AI (if applicable)