fix(sieve): fix handling of empty existing sieve scripts#13100
Open
hazveg wants to merge 1 commit into
Open
Conversation
Signed-off-by: hazveg <aaron.jaeger06@gmail.com>
|
Thanks for opening your first pull request in this repository! ✌️ |
Member
|
Thank you for the fix! I'll let Sieve engineer @kesselb handle this one :) |
Member
|
/backport to stable5.9 |
Member
|
/backport to stable5.10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch implements a check to more cleanly handle the case where the user's existing Sieve script is empty.
This occurs in the following two cases (from what I've tested):
This issue was first encountered when I implemented the redirect action in #13095 (See blank line at start of built script).
I must presume this wasn't an issue before now because every other implemented action in the Filter UI also needed to import something, somehow causing that empty string in
$linesto disappear. Debugging via Exceptions shows that an empty script file leads to a blank string at the start of$lines: