feat(signature): add setting to disable the "-- " separator above signatures#13098
feat(signature): add setting to disable the "-- " separator above signatures#13098joeldj-nl wants to merge 1 commit into
Conversation
ChristophWurst
left a comment
There was a problem hiding this comment.
Thank you for the contribution
Code looks good. Test coverage is appreciated
|
DCO is failing. Please sign off your commits. By signing off you guarantee that the contribution is compatible with the project's license. |
|
Thanks for your pull request. Thunderbird has a hidden flag to disable the separator too, so it probably makes sense to have it. That said, I would like to double-check if you are aware that this separator, while not strictly standardized (apart from being mentioned at https://www.rfc-editor.org/info/rfc3676/#section-4.3), is widely used to distinguish content from a signature. Many clients provide an option to split or hide on it. Removing the separator therefore reduces interoperability. Is there a particular reason why you need that switch? |
…natures Signed-off-by: Joël de Jager <contact@joeldejager.nl>
Thanks for the clarification. Yes, I’m aware that the The intention of this PR is not to change the default behavior. The new setting defaults to enabled, so existing interoperability is preserved unless a user explicitly opts out. The reason for the switch is that the separator is not desirable for every account or signature style. For modern/HTML or business signatures, the visible Since Thunderbird also provides a way to suppress the separator, I think it makes sense for Nextcloud Mail to expose this as an account-level preference as well: keep the interoperable behavior by default, but allow users to disable it when they intentionally prefer not to send the visible separator. |
Summary
The signature separator (
--) was previously always inserted above account signatures, with no way for users to disable it.This PR adds a per-account setting:
The setting is enabled by default to preserve the existing behavior for current users.
Changes
signatureAboveSeparatorsetting.Testing
Tested successfully in a fresh Nextcloud development installation.
Manual test performed:
--separator is no longer inserted above the signature.Notes
This keeps backward compatibility by defaulting the new option to enabled.
Assisted-by: Claude:claude-opus-4-8
🤖 AI (if applicable)