Create notification upon IMip message processing failure#12552
Create notification upon IMip message processing failure#12552Juniar-Rakhman wants to merge 3 commits intonextcloud:mainfrom
Conversation
fixup fixup fixup fixup
|
Thanks for opening your first pull request in this repository! ✌️ |
|
The changes in this PR are not ideal for us since iMIP messages are time-sensitive and most of our users do not use the Nextcloud web interface. In our production instance, we address this by implementing both push and email notifications. The email notification sent to the user is similar to the one in the original PR. The custom code changes that have been working for us can be found here. Ideally, I would prefer to configure this notification similar to the "Activity" notifications:
For example, by adding a setting called "iMIP Processing Failure" under "Other activities". However, this would likely require more extensive changes to the Notifications app as well. For now, I think the changes in this PR are sufficient to address the main issue. |
|
Thank you for the PR, please give us some time to review it |




This is a follow up PR based on feedback on the original PR, which in turn is a follow up changes to a patch done for #10811
The patch to address above issue fixes the processing flow of iMip message processing. When a failure occurs, the batch job logs the error and continues processing the next iMIP message instead of failing the entire job.
Issue:
Although the patch resolves the processing problem, failures occur silently from the user’s perspective. The user is not informed when an iMIP message fails to process and therefore cannot take corrective action.
Solution:
Created a notification upon iMIP messaging failure that will be sent to message owner so they can take corrective actions.
Added the following changes: