fix(textblocks): guard removal of non existing text block#12544
Merged
fix(textblocks): guard removal of non existing text block#12544
Conversation
Member
Author
|
/backport to stable5.7 |
GretaD
approved these changes
Mar 10, 2026
hamza221
approved these changes
Mar 10, 2026
Contributor
|
Merci |
findIndex returns -1 when it can't find an element. -1 in splice will return the last element of the array. Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
ChristophWurst
force-pushed
the
fix/textblocks/delete-id-no-found
branch
from
b476c58 to
89df2c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
findIndex returns -1 when it can't find an element. -1 in splice will return the last element of the array.