feat(settings): add thread message order preference#12510
feat(settings): add thread message order preference#12510lukas-remis wants to merge 1 commit intonextcloud:mainfrom
Conversation
lukas-remis
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
|
Thanks a lot for your pr 👍 That looks like a nice enhancement. Could you try to fix the DCO check by signing off your commit? I think "settings" as scope is a bit wrong, because the main change is in the thread view. If a change touches multiple areas, it's fine to leave it out. |
Adds a "Thread message order" setting (Oldest first / Newest first) to the Mail appearance settings. The preference is stored under the key 'thread-order' and defaults to 'oldest' (existing behaviour). - PageController: expose preference via initial state - init.js: load preference into store on startup - mainStore: reverse getEnvelopesByThreadRootId when 'newest' - AppSettingsMenu: add radio group UI below the Sorting setting - PageControllerTest: update mock counts and expected preferences Closes nextcloud#12072 Signed-off-by: lukas-remis <lukas.remis@gmail.com>
lukas-remis
force-pushed
the
feat/thread-order-setting
branch
from
d3db1dc to
7536534
Compare
| delete updated[parentEnvelopeId] | ||
| this.pendingInlineReplies = updated | ||
| localStorage.setItem(`mail_pending_inline_replies_${userId}`, JSON.stringify(this.pendingInlineReplies)) | ||
| }, |
| }) | ||
|
|
||
| mainStore.setQuickActions(loadState('mail', 'quick-actions', [])) | ||
| mainStore.loadPendingInlineRepliesMutation(getCurrentUser()?.uid ?? '') |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
3 participants
Adds a "Thread message order" setting (Oldest first / Newest first) to the Mail appearance settings. The preference is stored under the key 'thread-order' and defaults to 'oldest' (existing behaviour).
Closes #12072