Repository navigation
fix(LogTable): load entries until screen is filled - #2334
Merged
Merged
Conversation
IntersectionObserver reports only changes of visibility. If loaded entries fit on the screen, the load-more row stays visible and no further entries load. Remount the observer after each load, so it reports the current visibility again. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Inline @nextcloud/dialogs and @nextcloud/vue in vitest, so components that import them can be mounted in tests. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
fix/2333/load-more-on-tall-screen
branch
from
October 26, 2026 09:38
d4bde2d to
3522218
Compare
pringelmann
approved these changes
Oct 26, 2026
Collaborator
Author
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Collaborator
Author
Collaborator
Author
Collaborator
Author
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
:key="logStore.allEntries.length"will remount the observer after each load, so it reports the current visibility again.2333-after.mp4
馃 AI (if applicable)