fix: ability to exit failed text editor#4036
Open
towynlin wants to merge 1 commit intonextcloud:masterfrom
Open
fix: ability to exit failed text editor#4036towynlin wants to merge 1 commit intonextcloud:masterfrom
towynlin wants to merge 1 commit intonextcloud:masterfrom
Conversation
Show the back button so users don't have to kill the app. Detect failed web view navigation and show error banner. Signed-off-by: Zachary Crockett <zachary.crockett@hey.com>
Collaborator
|
Hi! Thank you for this, I will check it out soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why?
I have a nextcloud server and often use the iOS app for editing markdown files like simple to-do lists or grocery lists. Something that happens to me constantly that's frustrating is that I'll open a markdown file, edit a bit, lock my phone or navigate away to another app, then a few minutes later open the nextcloud app again to continue editing, but the page looks like this, and my only solution is to kill the app:
With the changes in this PR, the back button is shown at the top so I don't have to kill the app and can exit more gracefully. Also I added code with unit tests to detect the various failure conditions that lead to this and proactively handle them in the text editor view. Here's a screenshot with the back button showing.
(The difference in placement of banner is only because one screenshot is iPhone 17 while the other is iPhone 17 Pro, nothing to do with these changes.)
Where should reviewers focus?
Was there a reason the back button was hidden? Otherwise, this is a pretty small and straightforward fix.