-
Notifications
You must be signed in to change notification settings - Fork 2.5k
fix(webdav): correct X-NC-WebDAV-Auto-Mkcol header name in docs #15422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SomSamantray
wants to merge
2
commits into
nextcloud:master
Choose a base branch
from
SomSamantray:fix/webdav-automkcol-header
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| --- | ||
| title: Fix X-NC-WebDAV-AutoMkcol header name in WebDAV client API docs | ||
| date: 2026-08-07 | ||
| artifact_contract: ce-unified-plan/v1 | ||
| artifact_readiness: implementation-ready | ||
| execution: code | ||
| product_contract_source: ce-plan-bootstrap | ||
| origin: issue #15365 (https://github.com/nextcloud/documentation/issues/15365) | ||
| depth: lightweight | ||
| settled_decision_conflicts: [] | ||
| --- | ||
|
|
||
| # Fix X-NC-WebDAV-AutoMkcol header name in WebDAV client API docs | ||
|
|
||
| ## Problem Frame | ||
|
|
||
| The developer manual documents the optional upload header as | ||
| `X-NC-WebDAV-AutoMkcol` in `developer_manual/client_apis/WebDAV/basic.rst` | ||
| at two places (lines 111 and 615). The Nextcloud server reads | ||
| `X-NC-WebDAV-Auto-Mkcol` (with a second hyphen) in | ||
| `apps/dav/lib/Upload/UploadAutoMkcolPlugin.php` (line 41 of nextcloud/server | ||
| master). Clients following the documentation send the wrong header and | ||
| receive a 403 on uploads that should auto-create parent directories. | ||
|
|
||
| ## Requirements | ||
|
|
||
| - R1. Rename the header from `X-NC-WebDAV-AutoMkcol` to | ||
| `X-NC-WebDAV-Auto-Mkcol` in both occurrences in | ||
| `developer_manual/client_apis/WebDAV/basic.rst`. | ||
| - R2. No other file in the repository may contain the misspelled | ||
| `AutoMkcol` variant after the change (verified by repository-wide grep). | ||
| - R3. The fix is documentation-only; no source code of this repository | ||
| changes, and no server-side behavior is proposed or requested. | ||
|
|
||
| ## Scope Boundary | ||
|
|
||
| In scope: the two header-name occurrences in `basic.rst`. | ||
|
|
||
| Out of scope: | ||
| - Any change to server code (the server name is canonical). | ||
| - Reformatting or rewording the affected tables beyond the header name. | ||
| - Other documented headers or WebDAV endpoint behavior. | ||
|
|
||
| ## Key Technical Decisions | ||
|
|
||
| - KTD-1 (user-directed): use `X-NC-WebDAV-Auto-Mkcol` as the corrected name. | ||
| Rejected alternative: keeping `AutoMkcol` — the server's | ||
| `UploadAutoMkcolPlugin` checks `X-NC-WebDAV-Auto-Mkcol`; the docs are | ||
| wrong, not the server. Evidence: nextcloud/server | ||
| `apps/dav/lib/Upload/UploadAutoMkcolPlugin.php:41`. | ||
|
|
||
| ## Assumptions | ||
|
|
||
| - The server-side header name remains stable for the current and upcoming | ||
| documented versions (the plugin line was verified on server master). | ||
| - The reporter's observed 403 was caused by the header mismatch; the fix | ||
| aligns docs with server behavior. | ||
|
|
||
| ## Implementation Units | ||
|
|
||
| ### U-1 Rename header in WebDAV request-headers table | ||
|
|
||
| Files: `developer_manual/client_apis/WebDAV/basic.rst` | ||
|
|
||
| - Line 111 (PUT row in the request-methods table): replace | ||
| ``X-NC-WebDAV-AutoMkcol`` with ``X-NC-WebDAV-Auto-Mkcol`` inside the | ||
| existing literal markup, keeping the table cell width intact. | ||
| - Line 615 (request-headers table row): replace the header cell | ||
| ``X-NC-WebDAV-AutoMkcol`` with ``X-NC-WebDAV-Auto-Mkcol`` and widen the | ||
| first table column to fit the longer name, keeping the RST grid-table | ||
| borders aligned (re-run `sphinx-build`/`rst-lint` equivalent check or | ||
| visually verify the table renders). | ||
|
|
||
| Verification: | ||
| 1. Repository-wide grep for `AutoMkcol` (excluding the hyphenated variant) | ||
| returns zero matches. | ||
| 2. Grep confirms both `X-NC-WebDAV-Auto-Mkcol` occurrences exist at the | ||
| expected lines. | ||
| 3. RST table structure remains valid (grid-table column widths consistent; | ||
| doc build succeeds or cell borders line up). | ||
|
|
||
| ## Dependencies and Sequencing | ||
|
|
||
| Single unit; no ordering constraints. | ||
|
|
||
| ## Risks | ||
|
|
||
| - RST grid tables break silently when column widths are edited | ||
| incorrectly — mitigation is the table-validity check in U-1 verification. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think this should be committed ;)