Replace UNIX sockets with XPC on macOS

[i2h3]

The extensions shipped with our app should use XPC exclusively for interprocess communication and drop UNIX file sockets.

This needs to be integrated early in the development cycle for 34.0.0 and without a backport due to its impact and to maximize the verification time.

[Copilot]

Pull request overview

This pull request replaces UNIX socket-based IPC with XPC (Apple's Inter-Process Communication) for communication between the Nextcloud desktop client and its macOS FinderSync extension. This modernizes the macOS integration to use Apple's recommended XPC framework instead of file-based sockets.

Changes:

• Introduced XPC-based communication infrastructure (FinderSyncXPC, FinderSyncService, FinderSyncXPCManager) to replace socket-based communication
• Removed legacy socket server components (FileProviderSocketServer, FileProviderSocketController, FinderSyncSocketLineProcessor)
• Added XPC protocol definitions (FinderSyncProtocol, FinderSyncAppProtocol) for bidirectional communication
• Updated FinderSync extension to use XPC client instead of socket client
• Maintained SocketApi as the core business logic layer (reused for XPC transport)

Reviewed changes

Copilot reviewed 34 out of 35 changed files in this pull request and generated 17 comments.

Show a summary per file

File	Description
src/gui/macOS/findersyncxpc_mac.mm	New XPC listener implementation for accepting FinderSync connections
src/gui/macOS/findersyncxpc.h	XPC manager interface for broadcasting status updates to extensions
src/gui/macOS/findersyncservice.mm	XPC service delegate implementing FinderSyncAppProtocol for extension requests
src/gui/macOS/findersyncservice.h	Service interface wrapping SocketApi for XPC transport
src/gui/socketapi/socketapi.cpp	Added XPC broadcast support alongside socket broadcasts
src/gui/socketapi/socketapi.h	Added friend declaration for FinderSyncService to access FileData
src/gui/application.cpp	Initialize XPC infrastructure on macOS
shell_integration/.../FinderSyncXPCManager.m	XPC client for FinderSync extension to connect to main app
shell_integration/.../FinderSync.m	Migrated from socket client to XPC manager
src/gui/macOS/fileprovidersocketserver*.*	Removed legacy socket server (File Provider uses XPC now)
src/gui/CMakeLists.txt	Updated build to include new XPC files and remove socket files

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 33 out of 33 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[nilsding]

Some comments for now -- couldn't manage to get the FinderSync XPC connection working in a local dev setup due to sandboxing issues :(

[github-actions]

Artifact containing the AppImage: nextcloud-appimage-pr-9463.zip

Digest: sha256:a93463f8cf0379f37998b04bd98859e538f50fb99eb7fcaa1a4507e88a25f157

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

[sonarqubecloud]

Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)
51 New Code Smells (required ≤ 0)
D Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE