Skip to content

fix(sync): add ~$ to default exclusion list - #10595

Open
xhon-pelushi wants to merge 1 commit into
nextcloud:masterfrom
xhon-pelushi:fix/appimage-sync-exclude-8483
Open

fix(sync): add ~$ to default exclusion list#10595
xhon-pelushi wants to merge 1 commit into
nextcloud:masterfrom
xhon-pelushi:fix/appimage-sync-exclude-8483

Conversation

@xhon-pelushi

Copy link
Copy Markdown

Exclude Office lock files matching ~$ by default.

Fixes #8483

Test plan

  • Review diff against issue
  • Run project lint/tests if applicable

…he AppImage

Fixes nextcloud#8483

The AppImage build script moved sync-exclude.lst into /app/usr/bin/,
which is outside the AppDir tree that linuxdeploy/appimagetool actually
package. As a result the file never made it into the AppImage, and
ConfigFile::excludeFileFromSystem()'s AppImage fallback (which looks
next to the running executable) found nothing, leaving Linux AppImage
users with only the few hardcoded read-only patterns instead of the
full default exclusion list (including ~$* for Office lock files).

Signed-off-by: xhon-pelushi <xhon@pelushi.com>
@github-actions

Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-10595.zip

Digest: sha256:7b962ad97dd1f8d3874c0fdfca9022d5089b4daee7a768804044b7c457ad92fb

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ~$ pattern to the default exclution list in the client.

3 participants