Skip to content

🕵️ Add sharereview support - #8052

Open
AndyScherzinger wants to merge 1 commit into
mainfrom
feat/noid/sharereview
Open

🕵️ Add sharereview support#8052
AndyScherzinger wants to merge 1 commit into
mainfrom
feat/noid/sharereview

Conversation

@AndyScherzinger

@AndyScherzinger AndyScherzinger commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

Enabled the share review app to retrieve general share information and enabled the app to delete shares.

TODO

  • run CI
  • clarify share meta data

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@AndyScherzinger
AndyScherzinger force-pushed the feat/noid/sharereview branch 3 times, most recently from 935be19 to 6f0363f Compare June 11, 2026 16:18
AndyScherzinger
AndyScherzinger commented Jun 11, 2026
View reviewed changes
Comment thread lib/ShareReview/ShareReviewSource.php Outdated
@nextcloud nextcloud deleted a comment from github-actions Bot Jun 11, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot Jun 11, 2026
@AndyScherzinger
AndyScherzinger force-pushed the feat/noid/sharereview branch 4 times, most recently from b442ed4 to 21b2f12 Compare June 19, 2026 18:33
@AndyScherzinger
AndyScherzinger changed the base branch from main to feat/noid/share-metadata June 19, 2026 18:59
@AndyScherzinger
AndyScherzinger force-pushed the feat/noid/share-metadata branch from fe4ab81 to e7ede00 Compare June 19, 2026 19:00
@AndyScherzinger
AndyScherzinger force-pushed the feat/noid/sharereview branch from 21b2f12 to d7e4ccd Compare June 19, 2026 19:01
@AndyScherzinger
AndyScherzinger force-pushed the feat/noid/share-metadata branch 2 times, most recently from af1f803 to 7e3e603 Compare June 19, 2026 19:31
@AndyScherzinger AndyScherzinger mentioned this pull request Jun 19, 2026
Merged
6 tasks
@AndyScherzinger
AndyScherzinger force-pushed the feat/noid/sharereview branch from d7e4ccd to 28a991f Compare June 19, 2026 19:49
@nextcloud nextcloud deleted a comment from github-actions Bot Jun 22, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot Jun 22, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot Jun 22, 2026
@AndyScherzinger
AndyScherzinger force-pushed the feat/noid/sharereview branch 2 times, most recently from c4e3538 to b4e6d14 Compare June 22, 2026 17:12
@AndyScherzinger AndyScherzinger mentioned this pull request Jun 23, 2026
Merged
8 tasks
@AndyScherzinger
AndyScherzinger force-pushed the feat/noid/share-metadata branch from 7e3e603 to 4f1a9d7 Compare June 24, 2026 18:44
@AndyScherzinger
AndyScherzinger force-pushed the feat/noid/sharereview branch 2 times, most recently from 6391b51 to 4499e62 Compare June 25, 2026 13:59
Base automatically changed from feat/noid/share-metadata to main June 29, 2026 16:49
@AndyScherzinger
AndyScherzinger force-pushed the feat/noid/sharereview branch from 4499e62 to 85c7e73 Compare July 2, 2026 07:07
@AndyScherzinger
AndyScherzinger force-pushed the feat/noid/sharereview branch 2 times, most recently from 2478ddb to 9d1c95a Compare July 15, 2026 18:35
@github-actions

github-actions Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 200145 was 198420 (+0.86%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@AndyScherzinger
AndyScherzinger marked this pull request as ready for review August 19, 2026 19:16
@AndyScherzinger
AndyScherzinger changed the base branch from main to fix/noid/ocp-db-schema-api August 19, 2026 19:26
@AndyScherzinger
feat(sharereview): expose deck shares to share-review apps via OCP\Sh…
a548d19 
…are\ShareReview

Implement IShareReviewSource listing all deck shares with their
capabilities mapped to ShareReviewPermission entries, gate deletions
behind the ShareReviewAccessCheckEvent authorization check including
revocation of linked uploaded-files shares, and register the source
via RegisterShareReviewSourceEvent.

Assisted-by: Claude Code:claude-fable-5
Assisted-by: Claude Code:claude-opus-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
AndyScherzinger force-pushed the fix/noid/ocp-db-schema-api branch from 92cfd1e to b999059 Compare August 19, 2026 19:38
@github-actions

github-actions Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 200185 was 198420 (+0.88%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@github-actions

github-actions Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 200149 was 198420 (+0.87%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

Base automatically changed from fix/noid/ocp-db-schema-api to main August 19, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud luka-nextcloud is a code owner
@grnd-alt grnd-alt Awaiting requested review from grnd-alt grnd-alt is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

3. to review AI assisted enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AndyScherzinger