Skip to content

fix: show avatars in selector #7921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
grnd-alt wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −16
Open

fix: show avatars in selector #7921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 5 additions & 14 deletions src/components/card/AssignmentSelector.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,19 +19,9 @@
label="displayname"
track-by="multiselectKey"
@option:selected="onSelect"
@option:deselected="onRemove">
<template #tag="scope">
<div class="avatarlist--inline">
Copy link
Copy Markdown
Member Author

@grnd-alt grnd-alt May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this template in here was not rendered in the first place, user bubble is rendered by nextcloud/vue based on user-select

<NcAvatar :user="scope.option.uid"
:display-name="scope.option.displayname"
:size="24"
:is-no-user="scope.option.isNoUser"
:disable-menu="true" />
</div>
</template>
</NcSelect>
@option:deselected="onRemove" />
<div v-else class="avatar-list--readonly">
<NcAvatar v-for="option in assignedUsers"
<NcUserBubble v-for="option in assignedUsers"
:key="option.primaryKey"
:user="option.uid"
:display-name="option.displayname"
Expand All @@ -43,15 +33,15 @@

<script>
import { defineComponent } from 'vue'
import { NcAvatar, NcSelect } from '@nextcloud/vue'
import { NcSelect, NcUserBubble } from '@nextcloud/vue'
import AccountMultiple from 'vue-material-design-icons/AccountMultipleOutline.vue'

export default defineComponent({
name: 'AssignmentSelector',
components: {
AccountMultiple,
NcSelect,
NcAvatar,
NcUserBubble,
},
props: {
card: {
Expand Down Expand Up @@ -116,6 +106,7 @@ export default defineComponent({
...item.participant,
isNoUser: item.participant.type !== 0,
multiselectKey: item.participant.type + ':' + item.participant.primaryKey,
user: item.participant.uid,
}))
} else {
this.assignedUsers = []
Expand Down
4 changes: 2 additions & 2 deletions src/components/card/DueDateSelector.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
</NcActionButton>
</NcActions>

<NcButton v-if="!card.done"
<NcButton v-if="!card.done && canEdit"
type="secondary"
class="completed-button"
@click="changeCardDoneStatus()">
Expand All @@ -67,7 +67,7 @@
{{ formatReadableDate(duedate) }}
</span>
</div>
<div class="due-actions">
<div v-if="canEdit" class="due-actions">
<NcButton v-if="!card.archived"
type="tertiary"
:name="t('deck', 'Not done')"
Expand Down
Loading