Skip to content

fix(local-controller): include CFG_OPEN in config mask for visible circles#2545

Open
cristianscheid wants to merge 1 commit into
masterfrom
fix/noid/circles-visible-config-mask
Open

fix(local-controller): include CFG_OPEN in config mask for visible circles#2545
cristianscheid wants to merge 1 commit into
masterfrom
fix/noid/circles-visible-config-mask

Conversation

@cristianscheid

@cristianscheid cristianscheid commented Jun 19, 2026

Copy link
Copy Markdown
Member

Summary

  • the related PR linked above introduced a regression
    • for context, a circle's config is a bitwise integer, as seen here
    • the idea was to not expose the full config of a circle to non-members on GET ocs/v2.php/apps/circles/circles
    • to achieve that, the returned config was stripped down to only Circle::CFG_VISIBLE for non-members
    • however, one oversight is that Circle::CFG_OPEN is also needed by the frontend to decide whether a user can request to join
  • this PR fixes that, so when a non-member fetches a "visible to everyone" circle, instead of returning only Circle::CFG_VISIBLE, value of Circle::CFG_OPEN is also returned
  • before this fix, if john creates test_team with CFG_VISIBLE and CFG_OPEN enabled, bob can see the circle but cannot request to join
  • after this fix, bob can see and use the "request to join" option again, since Circle::CFG_OPEN is included
  • all other configs returned on circle object remain hidden for non-members, preserving the intent of the original PR

Screenshots

john's circle bob screen (before fix) bob screen (after fix)
John's circle config Bob before fix Bob after fix

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

…rcles

Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
@cristianscheid

Copy link
Copy Markdown
Member Author

/backport to stable34

@cristianscheid

Copy link
Copy Markdown
Member Author

/backport to stable33

@cristianscheid

Copy link
Copy Markdown
Member Author

/backport to stable32

@cristianscheid

Copy link
Copy Markdown
Member Author

/backport to stable31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant