Prevent opening the assistant dialog multiple times#523
Open
Prevent opening the assistant dialog multiple times#523
Conversation
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
added
bug
kyteinsky
approved these changes
May 5, 2026
Contributor
kyteinsky
left a comment
kyteinsky
left a comment
There was a problem hiding this comment.
just a suggestion: maybe the button can be disabled/used as a toggle in addition to this change
the toggle part maybe only works if the visibility is toggled, isn't great when the div is unmunted I suppose.
marcelklehr
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the dialog is not modal anymore, it is possible to open it multiple times because we can interact with the UI elements that trigger that.
This fix prevents that from happening when it is opened from:
openAssistantFormIn a nutshell: We remember when it's opened and we remember when it is closed (the Vue instance is unmounted).