Skip to content

ci: replace PHP 8.2 with PHP 8.4 in the PHPUnit matrix#899

Merged
oleksandr-nc merged 1 commit into
mainfrom
ci/phpunit-drop-php-8.2
Jun 19, 2026
Merged

ci: replace PHP 8.2 with PHP 8.4 in the PHPUnit matrix#899
oleksandr-nc merged 1 commit into
mainfrom
ci/phpunit-drop-php-8.2

Conversation

@bigcat88

@bigcat88 bigcat88 commented Jun 19, 2026

Copy link
Copy Markdown
Member

The PHPUnit workflow runs its matrix against Nextcloud server master, which recently raised its minimum to PHP 8.3, so the old PHP 8.2 leg fails before any test runs (maintenance:install aborts with "requires at least PHP 8.3").

Instead of just dropping 8.2, this adds PHP 8.4 alongside 8.3: the matrix now runs PHP 8.3 and 8.4 against server master. That keeps two-version coverage and tests against the newest PHP that master supports.

Lint jobs and the 8.2 min-version in info.xml are left as-is, since AppAPI still runs on 8.2 under older Nextcloud releases; only the master-branch PHPUnit job needs a PHP the server accepts.

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The PHPUnit GitHub Actions workflow matrix is updated to remove PHP 8.2 and add PHP 8.4, resulting in a test matrix of ['8.3', '8.4']. This single-line change in .github/workflows/phpunit.yml adjusts which PHP versions the workflow tests against; no other workflow steps, jobs, or configuration are modified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately describes the main change: replacing PHP 8.2 with PHP 8.4 in the PHPUnit workflow matrix, which is the primary modification in the changeset.
Description check ✅ Passed The description is directly related to the changeset, providing context about why PHP 8.2 was replaced (Nextcloud server master's new PHP 8.3 minimum requirement) and explaining the decision to add PHP 8.4.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
@oleksandr-nc oleksandr-nc force-pushed the ci/phpunit-drop-php-8.2 branch from e040005 to 0f89f4a Compare June 19, 2026 12:49

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: df1bbc58-f61a-4c01-8a43-784a7b291a29

📥 Commits

Reviewing files that changed from the base of the PR and between e040005 and 0f89f4a.

📒 Files selected for processing (1)
  • .github/workflows/phpunit.yml

Comment thread .github/workflows/phpunit.yml
@oleksandr-nc oleksandr-nc changed the title ci: drop PHP 8.2 from PHPUnit matrix as server master requires PHP 8.3 ci: replace PHP 8.2 with PHP 8.4 in the PHPUnit matrix Jun 19, 2026
@oleksandr-nc oleksandr-nc requested a review from kyteinsky June 19, 2026 13:51
@oleksandr-nc oleksandr-nc merged commit 469063e into main Jun 19, 2026
53 checks passed
@oleksandr-nc oleksandr-nc deleted the ci/phpunit-drop-php-8.2 branch June 19, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants