Skip to content

Enable app optimization with R8 - #17699

Draft
PhilLab wants to merge 2 commits into
masterfrom
r8_minify
Draft

PhilLab wants to merge 2 commits into
masterfrom
r8_minify

Conversation

@PhilLab

@PhilLab PhilLab commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

Related to #17640

With keeping the apache httpclient, webdav and ical4j, the app at least
starts.

But it crashes when clicking the plus button (OCFileListBottomSheetDialog).

Related to #17640

Assisted-by: GithubCopilot:GPT-5.4
Signed-off-by: Philipp Hasper <vcs@hasper.info>
@PhilLab
PhilLab marked this pull request as draft September 23, 2026 14:29
@PhilLab PhilLab added enhancement performance 🚀 Performance improvement opportunities (non-crash related) labels Sep 23, 2026
@codecov

codecov Bot commented Sep 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions

github-actions Bot commented Sep 23, 2026

Copy link
Copy Markdown

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 185f57e
Version 17699
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

This adds a property to enable the optimization, and it is activated for
the CI
- build
- screenshot tests
- instrumentation tests
- unit test (though probably without effect)

For this to work, it must also be present in the debug build variant

Signed-off-by: Philipp Hasper <vcs@hasper.info>
@github-actions

Copy link
Copy Markdown

master-IT test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

Copy link
Copy Markdown

stable22-IT test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

Copy link
Copy Markdown

stable35-IT test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3232
Correctness5858
Dodgy code186185
Experimental11
Malicious code vulnerability22
Multithreaded correctness2626
Performance3737
Security1818
Total360359

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI assisted enhancement performance 🚀 Performance improvement opportunities (non-crash related)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant