Add a favorite icon to the search screen#17140
Conversation
alperozturk96
force-pushed
the
feature/favorite_icon_in_search
branch
from
18b6e93 to
b4233d2
Compare
| } | ||
|
|
||
| private fun bindFavoriteIndicator(entry: SearchResultEntry) { | ||
| val file = storageManager.getFileByRemotePath(entry.remotePath()) |
There was a problem hiding this comment.
I can see multiple DB read for same path
val file = storageManager.getFileByRemotePath(entry.remotePath())
Please only read beginning of the fun bind(entry: SearchResultEntry) once then use it below for others.
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
3 participants
It was added displaying of favorite icon while searching files/folders
