Skip to content

fix(auto-upload): clean stale upload entities#16712

Open
alperozturk96 wants to merge 5 commits intomasterfrom
fix/auto-upload-clear-upload-db-when-auto-upload-delete-or-disabled
Open

fix(auto-upload): clean stale upload entities#16712
alperozturk96 wants to merge 5 commits intomasterfrom
fix/auto-upload-clear-upload-db-when-auto-upload-delete-or-disabled

Conversation

@alperozturk96
Copy link
Collaborator

Issue

When a synced folder is disabled or deleted, its associated OCUpload entries in the uploads
table must be cleaned up. Without this, stale upload entries outlive the folder config that
created them, causing FileUploadWorker to keep retrying uploads for a folder that no longer
exists or is intentionally turned off, and AutoUploadWorker to re-queue already handled files
on its next scan via FileSystemRepository.getFilePathsWithIds.

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions
Copy link

APK file: https://github.com/nextcloud/android/actions/runs/23338813176/artifacts/6023879981
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

…pload folder

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions
Copy link

Codacy

SpotBugs

CategoryBaseNew
Bad practice4040
Correctness7272
Dodgy code237237
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4343
Security1818
Total454454

@github-actions
Copy link

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions
Copy link

APK file: https://github.com/nextcloud/android/actions/runs/23340161367/artifacts/6024223748
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant