Skip to content

fix(share): icons #16418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alperozturk96 wants to merge 4 commits into
base: master
Choose a base branch
from
+33 −18
Open

fix(share): icons #16418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
212a11a
fix(share): internal link alignment
alperozturk96 Jan 30, 2026
e1a91f4
fix(share): drop down icon visibility
alperozturk96 Jan 30, 2026
b2ee550
make imageview material icon button
alperozturk96 Jan 30, 2026
55e5326
make imageview material icon button
alperozturk96 Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/src/main/java/com/owncloud/android/ui/adapter/LinkShareViewHolder.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,11 +134,11 @@ internal class LinkShareViewHolder(itemView: View) : RecyclerView.ViewHolder(ite

if (TextUtils.isEmpty(permissionName) || (isSecureFileDrop(publicShare) && encrypted)) {
binding.permissionName.visibility = View.GONE
return
} else {
binding.permissionName.visibility = View.VISIBLE
binding.permissionName.text = permissionName
}

binding.permissionName.text = permissionName
binding.permissionName.visibility = View.VISIBLE
viewThemeUtils?.androidx?.colorPrimaryTextViewElement(binding.permissionName)
}

Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/layout/file_details_share_internal_share_link.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
android:background="@drawable/round_bgnd"
android:contentDescription="@string/share"
android:id="@+id/copy_internal_link_icon"
android:layout_gravity="top"
android:layout_gravity="center"
android:layout_height="@dimen/share_icon_size"
android:layout_marginEnd="@dimen/standard_margin"
android:layout_marginStart="@dimen/standard_margin"
Expand Down
27 changes: 18 additions & 9 deletions app/src/main/res/layout/file_details_share_link_share_item.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,38 +63,47 @@

<androidx.appcompat.widget.AppCompatTextView
android:id="@+id/permission_name"
android:visibility="gone"
tools:visibility="visible"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:gravity="center_vertical"
android:singleLine="true"
tools:text="@string/placeholder_view_only"
android:drawablePadding="@dimen/standard_quarter_margin"
app:drawableEndCompat="@drawable/ic_baseline_arrow_drop_down_24"
app:drawableTint="@color/primary"
app:drawableRightCompat="@drawable/ic_baseline_arrow_drop_down_24"
android:textColor="@color/primary"
android:textSize="@dimen/two_line_secondary_text_size" />
</LinearLayout>

<ImageView
<com.google.android.material.button.MaterialButton
android:id="@+id/copy_link"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
style="?attr/materialIconButtonStyle"
android:layout_width="@dimen/minimum_size_for_touchable_area"
android:layout_height="@dimen/minimum_size_for_touchable_area"
android:layout_gravity="center_vertical"
android:contentDescription="@string/copy_link"
android:paddingStart="@dimen/standard_padding"
android:paddingTop="@dimen/standard_quarter_margin"
android:paddingEnd="@dimen/standard_padding"
android:paddingBottom="@dimen/standard_quarter_margin"
android:scaleType="fitCenter"
android:src="@drawable/ic_content_copy" />
app:iconTint="@color/text_color"
app:icon="@drawable/ic_content_copy"
app:iconGravity="textStart" />

<ImageView
<com.google.android.material.button.MaterialButton
android:id="@+id/overflow_menu"
android:layout_width="wrap_content"
android:layout_height="match_parent"
style="?attr/materialIconButtonStyle"
android:layout_gravity="center"
android:layout_width="@dimen/minimum_size_for_touchable_area"
android:layout_height="@dimen/minimum_size_for_touchable_area"
android:contentDescription="@string/overflow_menu"
android:paddingStart="@dimen/standard_padding"
android:paddingEnd="@dimen/standard_padding"
android:src="@drawable/ic_dots_vertical" />
app:icon="@drawable/ic_dots_vertical"
app:iconTint="@color/text_color"
app:iconGravity="textStart" />

</LinearLayout>
16 changes: 11 additions & 5 deletions app/src/main/res/layout/file_details_share_share_item.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,24 +51,30 @@

<androidx.appcompat.widget.AppCompatTextView
android:id="@+id/permission_name"
android:visibility="gone"
tools:visibility="visible"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:gravity="center_vertical"
android:singleLine="true"
android:textColor="@color/primary"
android:textSize="@dimen/two_line_secondary_text_size"
android:drawablePadding="4dp"
app:drawableEndCompat="@drawable/ic_baseline_arrow_drop_down_24"
app:drawableRightCompat="@drawable/ic_baseline_arrow_drop_down_24"
app:drawableTint="@color/primary"
tools:text="@string/placeholder_view_only" />
</LinearLayout>

<ImageView
<com.google.android.material.button.MaterialButton
android:id="@+id/overflow_menu"
android:layout_width="wrap_content"
android:layout_height="match_parent"
style="?attr/materialIconButtonStyle"
android:layout_gravity="center"
android:layout_width="@dimen/minimum_size_for_touchable_area"
android:layout_height="@dimen/minimum_size_for_touchable_area"
android:contentDescription="@string/overflow_menu"
android:paddingStart="@dimen/standard_padding"
android:paddingEnd="@dimen/standard_padding"
android:src="@drawable/ic_dots_vertical" />
app:icon="@drawable/ic_dots_vertical"
app:iconTint="@color/text_color"
app:iconGravity="textStart" />
</LinearLayout>
Loading