Skip to content

feat(assistant): translate #16326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
alperozturk96 wants to merge 24 commits into
base: master
Choose a base branch
from
Open

feat(assistant): translate #16326

alperozturk96 wants to merge 24 commits into from
+836 −34

Conversation

@alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Jan 20, 2026 •
edited
Loading

  • Tests written, or not not needed

Implements second part of it: nextcloud/files-clients#89 (comment)

Library PR: nextcloud/android-library#1933

@alperozturk96 alperozturk96 requested a review from kra-mo January 20, 2026 15:04
@alperozturk96 alperozturk96 marked this pull request as draft January 20, 2026 15:04
@alperozturk96 alperozturk96 force-pushed the feat/action-process-text-support branch from 68b8c32 to 61bf192 Compare January 21, 2026 09:55
@alperozturk96 alperozturk96 marked this pull request as ready for review January 21, 2026 09:56
@alperozturk96 alperozturk96 marked this pull request as draft January 21, 2026 09:56
@alperozturk96 alperozturk96 force-pushed the feat/translate-task-type branch 2 times, most recently from 4ecd0e2 to 2842d25 Compare January 21, 2026 10:01
@alperozturk96 alperozturk96 force-pushed the feat/action-process-text-support branch from 77ffc2b to 5eeae80 Compare January 21, 2026 10:14
@alperozturk96 alperozturk96 force-pushed the feat/translate-task-type branch 2 times, most recently from 6e7c54b to 747223e Compare January 21, 2026 11:29
Base automatically changed from feat/action-process-text-support to master January 21, 2026 13:36
@alperozturk96 alperozturk96 force-pushed the feat/translate-task-type branch from f5f80f6 to 1bd9a81 Compare January 21, 2026 13:42
@nimishavijay
Copy link
Member

nimishavijay commented Jan 21, 2026 •
edited by alperozturk96
Loading

Good question. It seems very cumbersome to read long text in this half-screen-scrolling UI. I am assuming that most people will paste the text from somewhere else, in which case the specifics of the original text doesn't matter much. We can just keep the header bar sticky and scroll the rest like usual.

Other than that, 2 small points:

  • "Source language" seems a bit technical, we can change that to "Translate from"
  • It is not obvious from the UI that there is a dropdown for the languages, so we should add a small chevron-down icon next to the language.
  • There's also a floating button and I am not sure what it does (is it a button to force translation or create a "new translation task"?). would it be possible to just automatically translate whenever the source text changes (maybe throttled to 500ms or something to avoid sending too many requests)?

@alperozturk96 alperozturk96 force-pushed the feat/translate-task-type branch from 0860e36 to f158729 Compare January 22, 2026 09:20
@alperozturk96 alperozturk96 marked this pull request as ready for review January 22, 2026 14:21
@alperozturk96

This comment was marked as resolved.

Sign in to view
@alperozturk96 alperozturk96 force-pushed the feat/translate-task-type branch from 4489c04 to 4b1aae2 Compare January 22, 2026 15:04
kra-mo

This comment was marked as resolved.

Sign in to view

@alperozturk96 alperozturk96 force-pushed the feat/translate-task-type branch from 4b1aae2 to 9ce6c24 Compare January 23, 2026 14:31
@alperozturk96 alperozturk96 force-pushed the feat/translate-task-type branch 3 times, most recently from 01d407c to d586a61 Compare January 27, 2026 12:30
@alperozturk96 alperozturk96 requested a review from kra-mo January 27, 2026 14:34
@alperozturk96 alperozturk96 force-pushed the feat/translate-task-type branch from 5fa9c4c to 530d6cf Compare January 28, 2026 10:20
@github-actions
Copy link

github-actions bot commented Jan 28, 2026

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16326.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@alperozturk96
feat(assistant): translate
1d8846f 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

# Conflicts:
#	gradle/libs.versions.toml

# Conflicts:
#	app/src/main/java/com/nextcloud/client/assistant/AssistantScreen.kt
@alperozturk96
fix git conflict
72f1d55 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
copy selected text to input bar
4348720 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
add translation model
c557fdc 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
add translation logic
722ea8c 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

# Conflicts:
#	app/src/main/res/values/strings.xml
@alperozturk96
add translation logic
4d47777 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
add translation logic
603412a 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
add translation logic
ea869cc 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
add translation task select
4c2bd6d 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix layout update
abfdb90 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix layout update
51ecf58 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
handle task select
673b209 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
handle task select
edf2ce1 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix translation flow
df0be8a 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix translation flow
7207732 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix translation flow
2326f3f 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
better ui ux
70eb5b1 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
better ui ux
7e4bc49 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
better ui ux
67b95c1 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
better ui ux
c8c6220 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
add polling for task selection
cc6bf85 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix ux
e99976e 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix ux
52237b1 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix ux
7bfc65d 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the feat/translate-task-type branch from 530d6cf to 7bfc65d Compare January 30, 2026 13:52
@github-actions
Copy link

github-actions bot commented Jan 30, 2026

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kra-mo kra-mo kra-mo approved these changes

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alperozturk96 @nimishavijay @kra-mo