fix(NcSelect): floating label design using NcTextField#8570
Open
skjnldsv wants to merge 1 commit into
Open
Conversation
skjnldsv
added
enhancement
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8570 +/- ##
==========================================
+ Coverage 54.55% 55.28% +0.73%
==========================================
Files 106 106
Lines 3439 3451 +12
Branches 1002 1007 +5
==========================================
+ Hits 1876 1908 +32
+ Misses 1322 1308 -14
+ Partials 241 235 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
skjnldsv
added
bug
skjnldsv
force-pushed
the
fix/ncselect-design
branch
2 times, most recently
from
54aa738 to
86ca380
Compare
skjnldsv
added
3. to review
skjnldsv
requested review from
hamza221,
jancborchardt,
kra-mo and
marcoambrosini
and removed request for
Copilot
skjnldsv
force-pushed
the
fix/ncselect-design
branch
from
86ca380 to
2f91d67
Compare
Replace the plain `<input>` in NcSelect's search slot with NcTextField to get consistent floating label, border, and focus styling across all form fields. Single mode: - NcTextField owns the border and floating label - Selected value overlays the input (position: absolute, z-index: 2) - Label floats on focus or when value selected via :has(.vs__selected) Multi mode: - Border on .vs__dropdown-toggle (contains tags + search input) - Floating label via #header slot, centered when empty, floats on border when tags present or dropdown open - Search input inline with tags (flex-grow, no layout jump on open) - Tags hidden behind actions prevented via padding-inline-end Drop-up: - Border/radius inverted (transparent top, rounded bottom) - Label moves to bottom border Other fixes: - Forward vue-select events (keydown, blur, focus, IME) via filterEvents() to reach the native <input> - Scope CSS variables to .v-select.select (not body) - Dropdown menu variables set directly (teleported to body by floating-ui, can't inherit from .v-select.select) - Inline inputLikeBorder mixin to fix @media doubled-selector bug - Dark/light theme border overrides with correct selectors - No-wrap overflow clips before actions area Signed-off-by: skjnldsv <skjnldsv@users.noreply.github.com> Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/ncselect-design
branch
from
2f91d67 to
e9d00bd
Compare
jancborchardt
requested changes
May 27, 2026
Contributor
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Very nice! :) 2 details:
- Both "multiple" inputs now have inverted shadow effect. It should seem inset (dark shadow from the top, light on the bottom)
- The border of the select when open is too strong. Our
--color-border-maxcontrastis confusing as unlike--color-text-maxcontrastit is not less contrasting but much more. What would look better is just using--color-borderhere.
Contributor
Author
You mean the entire border? This is the same it currently is. It is also the same as the Input field |
kra-mo
requested changes
May 28, 2026
Member
kra-mo
left a comment
kra-mo
left a comment
There was a problem hiding this comment.
Really nice, thank you!
But there seem to be issues with alignment and clipping:
And I think Jan means the entire border, which this indeed did not touch, so I'd say it's fine to keep for this pull request.
Member
|
Hmm, the alignment issue seems to be based on where in the viewport the fields are. It's only an issue when in the bottom half of the screen, if I see it correctly. |
Member
|
There also seems to be clipping here: 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Summary
Replace the plain
<input>in NcSelect's#searchslot withNcTextFieldso the component shares the same floating label, border, and focus styling asNcTextFieldandNcTextArea.🖼️ Screenshots
🚧 Tasks
🏁 Checklist
stable8for maintained Vue 2 version or not applicable