Repository navigation
fix(images): keep a turned picture's box to the size it is drawn at - #157
Merged
Merged
Conversation
A quarter turn draws the picture across the box it is laid out in. A tall picture turned kept its tall box, which overflowed the viewer: a scrollbar showed and the picture sat off centre. Margins give the box the turned size. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
==========================================
- Coverage 92.54% 92.49% -0.06%
==========================================
Files 51 51
Lines 4187 4185 -2
Branches 928 929 +1
==========================================
- Hits 3875 3871 -4
- Misses 289 291 +2
Partials 23 23 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turning a tall picture once made the viewer scroll: the picture is drawn turned, but its box kept its old, tall size and overflowed. Margins now give the box the turned size, so it stays centred with no scrollbar.
Zooming in still overflows the same way, on main too. That's for another PR.
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.