Skip to content

fix(viewer): name the compared files in the order they are shown - #154

Merged
skjnldsv merged 1 commit into
mainfrom
fix/comparison-title
Oct 20, 2026
Merged

skjnldsv merged 1 commit into
mainfrom
fix/comparison-title

Conversation

@mejo-

@mejo- mejo- commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

The title of a comparison named the newer file first, while the viewer shows the older one on the left. It names the older one first now.

Assisted-by: ClaudeCode:claude-opus-5-5

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

The title of a comparison named the newer file first, while the viewer
shows the older one on the left. It names the older one first now.

Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: ClaudeCode:claude-opus-5-5
@mejo- mejo- self-assigned this Oct 20, 2026
@mejo- mejo- added the type: bug 🐛 Something isn't working label Oct 20, 2026
@mejo-
mejo- requested a review from skjnldsv as a code owner October 20, 2026 07:24
@codecov

codecov Bot commented Oct 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.54%. Comparing base (b2872ea) to head (b145fef).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
lib/views/Viewer.vue 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #154   +/-   ##
=======================================
  Coverage   92.54%   92.54%           
=======================================
  Files          51       51           
  Lines        4187     4187           
  Branches      928      928           
=======================================
  Hits         3875     3875           
  Misses        289      289           
  Partials       23       23           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mejo- added a commit to nextcloud/collectives that referenced this pull request Oct 20, 2026
Will be obsoleted by
nextcloud-libraries/nextcloud-viewer#154

Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: ClaudeCode:claude-opus-5-5
@skjnldsv
skjnldsv merged commit d3af1c0 into main Oct 20, 2026
19 of 20 checks passed
@skjnldsv
skjnldsv deleted the fix/comparison-title branch October 20, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review AI assisted type: bug 🐛 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants