Repository navigation
Conversation
A file given by its share's link, /s/<token>, cannot be fetched alone when the share is a folder: the link downloads the whole folder as a zip. Ask the share once whether it is a file or a folder, and show and download the file from its WebDAV address instead. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #151 +/- ##
==========================================
+ Coverage 92.53% 92.58% +0.05%
==========================================
Files 51 51
Lines 4177 4237 +60
Branches 922 936 +14
==========================================
+ Hits 3865 3923 +58
- Misses 289 290 +1
- Partials 23 24 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Sorry, still ongoing, not happy with what Claude came up with |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #146, for the files Talk hands a guest by their share's link,
/s/<token>/download/<name>. In a folder share that link serves the whole folder as a zip, so a file without a preview, or a click on Download, got the zip instead of the file.The link can't say whether the share is the file itself or a folder holding it. The viewer now asks the share once per page, with a depth 0
PROPFINDon/public.php/dav/files/<token>, and shows and downloads the file from its WebDAV address. A share that doesn't answer (password, error) keeps the link as before.The download keeps the name of the file that was opened: a file shared alone lives at
/public.php/dav/files/<token>, so the address alone would save it under the token.before-downloadstill carries that file too.Relates to #144
Covered by unit tests, Viewer component tests and a playground e2e. Not tested against a real Talk yet. A Download clicked while the
PROPFINDis still running uses the link.👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.