Repository navigation
feat(viewer): say what to expect on Nextcloud 35 and older - #148
Merged
Merged
Conversation
skjnldsv
added
type: enhancement
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
==========================================
+ Coverage 92.42% 92.44% +0.02%
==========================================
Files 49 50 +1
Lines 4103 4119 +16
Branches 898 903 +5
==========================================
+ Hits 3792 3808 +16
+ Misses 290 289 -1
- Partials 21 22 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
skjnldsv
force-pushed
the
feat/legacy-server-warning
branch
from
October 16, 2026 07:00
650d124 to
65869b9
Compare
The library runs next to the viewer app of older servers, which nothing warned about. The README says what was checked on 35, and the viewer logs a warning when it finds the viewer app, or a server that says it is older. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
skjnldsv
force-pushed
the
feat/legacy-server-warning
branch
from
October 16, 2026 07:44
65869b9 to
4f61388
Compare
CarlSchwan
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library runs on Nextcloud 35 next to the viewer app, but nothing said what that means. Checked on 35.0.2 with an app bundling the library: pictures, videos and sounds open in the library's viewer, from the app and from Files. The handlers other apps register with
OCA.Viewer, HEIC and TIFF previews, and saved settings are not there. So the viewer hides its settings there: no button, and?does nothing.The README gets a "Nextcloud 35 and older" section with that list. The viewer logs a warning when it mounts on such a server, found by the viewer app's
OCA.Viewer.registerHandler(the shim of 36 has none) or byOC.config.version.Only images, video and audio were checked.
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.