feat(dialog): experimental sharing dialog for the unified sharing API#239
Draft
skjnldsv wants to merge 4 commits into
Draft
feat(dialog): experimental sharing dialog for the unified sharing API#239skjnldsv wants to merge 4 commits into
skjnldsv wants to merge 4 commits into
Conversation
Switch the build from plain tsc to @nextcloud/vite-config createLibConfig so the package can ship Vue SFCs in upcoming subpath exports. The three existing entry points (., ./public, ./ui) are preserved; only the dist file names change (.js -> .mjs, ui/index.js -> ui.mjs). Declarations are generated by vite-plugin-dts and rolled up in production mode. Also fixes the stale lib/publicShare.ts reference in build:doc. Assisted-by: ClaudeCode:claude-fable-5
… API Add a new ./dialog entry point shipping the sharing dialog built for the unified sharing API (Nextcloud >= 35): - openSharingDialog(node) spawns the dialog, gated on the sharing capability being present - SharingDialog component export for embedding - typed API client (createShare, addShareRecipient, selectSharePermissionPreset, ...) and response types - own gettext domain, translations bundled at build time The dialog is marked experimental: the server API is new and the module API may change in any minor release. Assisted-by: ClaudeCode:claude-fable-5
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
===========================================
- Coverage 95.65% 83.51% -12.14%
===========================================
Files 4 11 +7
Lines 69 182 +113
Branches 25 69 +44
===========================================
+ Hits 66 152 +86
- Misses 3 24 +21
- Partials 0 6 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Declaration rollup only ran in production mode, so dev/watch builds emitted nested d.ts files that did not match the flat paths in the exports map. Drop the rollup and point exports at the nested output, identical in both modes. Assisted-by: ClaudeCode:claude-fable-5
The unified sharing API replaced the view/edit preset enum with
registered preset classes carrying translated display names:
- capabilities now expose sharing.permission_presets with
{class, display_name, hint}, so the hardcoded preset label map is
gone and the dropdown is fully backend-driven
- permission.presets and permission_preset carry preset class strings
- the preset endpoint parameter was renamed to permissionPresetClass
Assisted-by: ClaudeCode:claude-fable-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP