Skip to content

fix: Avoid error when files are changed during tar #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DerDreschner wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

fix: Avoid error when files are changed during tar #1047

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/commands/state.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,13 @@ export function saveState(): Cypress.Chainable<string> {
const snapshot = Math.random().toString(36).substring(7)

runCommand(`rm /var/www/html/data-${snapshot}.tar`, { failOnNonZeroExit: false })
runCommand(`tar cf /var/www/html/data-${snapshot}.tar ./data`)
// The instance keeps writing into ./data while we archive it (e.g. the
// nextcloud.log, caches, session files), so a file can change mid-read and
// GNU tar exits 1 with "file changed as we read it". That is harmless for a
// test-state snapshot: silence the warning and treat exit 1 (benign,
// "some files differ") as success while still failing on a real error
// (exit 2, fatal).
runCommand(`tar --warning=no-file-changed -cf /var/www/html/data-${snapshot}.tar ./data || [ $? -eq 1 ]`)

cy.log(`Created snapshot ${snapshot}`)

Expand Down
Loading