upsdrvctl: re-check single driver startup just before retrying a start deemed failed#3537
Open
jimklimov wants to merge 3 commits into
Open
upsdrvctl: re-check single driver startup just before retrying a start deemed failed#3537jimklimov wants to merge 3 commits into
jimklimov wants to merge 3 commits into
Conversation
…aces [networkupstools#3302] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ed instance also for single device runs [networkupstools#3302] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…on [networkupstools#2567] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added
enhancement
service/daemon start/stop
|
A ZIP file with standard source tarball and another tarball with pre-built docs for commit 01b72ec is temporarily available: NUT-tarballs-PR-3537.zip. |
|
✅ Build nut 2.8.5.4971-master completed (commit d4fc915f94 by @jimklimov)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was previously checked only if more than one simultaneous driver start was attempted, which might involve some other decisions compared to a single-shot run. This particular change should not break anything.
Trouble noted in NIT suite runs where a 1-second timeout was not always enough for
dummyto start and fork into background, soupsdrvctllooped for 3 attempts with 5-second sleep between them (killing the driver that did start after say 2 seconds); eventually the tool gave up and the last-started driver instance lived on.