NXOS netmiko transport change#388
Open
mattmiller87 wants to merge 2 commits into
Open
Conversation
mattmiller87
requested review from
jeffkala,
pke11y and
pszulczewski
as code owners
mattmiller87
force-pushed
the
u/mattmiller/nxos_netmiko
branch
from
41e9c77 to
bc6dcd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Pull Request
This PR begins the work to migrate nxos away from pynxos, deprecate that code, and rely explicitly on netmiko.
This is a phased approach as some of the commands may require ntc-templates, textfsm, or custom parsers to complete some existing pynxos methods.
Change Notes
Deprecation of NXOSDevice.
Changed
NXOSDevicemethods from NX-API to Netmiko SSH:running_config,set_timeout,install_os,reboot,backup_running_config,checkpoint,rollback,redundancy_state,file_copy_remote_exists, andfile_copy.Justification
Pynxos has been stagnant for years and nxos support through netmiko makes the most sense at this time.
Some commands require a bit more work, and should be added to this PR or worked through a new PR for migration.