Fix lazy object inspection executing property hooks - #621
Open
mildabre wants to merge 1 commit into
Open
Conversation
Debugging tools should inspect existing object state, not execute property getter code. Virtual properties are excluded because they have no backing value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Tracy inspects a lazy object, reading a property via ReflectionProperty::getValue() may execute its getter hook.
This is unsafe for a debugging tool because a getter can execute arbitrary application code, mutate object state, initialize dependencies, or throw an exception — especially when the object is inspected in an incomplete lifecycle state.
This PR:
reads initialized properties using getRawValue() instead of getValue()
excludes virtual properties, which have no backing storage
keeps lazy and uninitialized properties excluded as before
A debugging tool should inspect the existing object state, not execute property getter code just to obtain a value.