Repository navigation
Conversation
fail() returns void because an Assert::$onFailure handler may swallow the failure, but like every other assertion it is meant to end the test. Co-Authored-By: Claude Code
xificurk
force-pushed
the
tester-assert-fail
branch
from
November 7, 2026 08:55
1eabd6b to
4de1668
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tester\Assert::fail()is now listed inearlyTerminatingMethodCalls, so code after it is treated as unreachable and type narrowing holds:fail()can't be declarednevernatively: it returnsvoidbecause anAssert::$onFailurehandler may swallow the failure and continue. Every type-narrowing assertion already assumes that a failed assertion ends the test, sofail()follows the same convention.