Skip to content

feat(references): contributing to repositories you do not own - #162

Merged
CybotTM merged 1 commit into
mainfrom
feat/upstream-contributions
Aug 25, 2026
Merged

feat(references): contributing to repositories you do not own#162
CybotTM merged 1 commit into
mainfrom
feat/upstream-contributions

Conversation

@CybotTM

@CybotTM CybotTM commented Aug 25, 2026

Copy link
Copy Markdown
Member

New reference: first contribution into a repository you do not own. Every rule in it exists because skipping it produced a public artifact that had to be walked back, all in one upstream engagement (FriendsOfTYPO3/fractor, 2026-08-25):

Rule What happened without it
Read the open issue AND PR lists, not just keyword searches Three searches empty; the repo's #427 described the same defect in other words, #430 already fixed it — duplicate issue and PR both closed with thanks
Measure comment style, don't import house style Two 5-line comment blocks were the longest in their entire codebase; a reviewer asked why
Draft-first The PR went out ready; the reviewer expected draft
Run ALL contributing steps composer docs was skipped
Revert what their fixers touched Rectify wanted to reformat four unrelated files into the PR
Assess by running, not by reading Running the competing fix against the own reproduction settled the maintainer's "does it fix your case?" in one comment

SKILL.md gains the When-to-Use trigger and the reference row. main sat at 499 of the 500-word cap, so existing prose is compressed to make room — the commit message lists each compression; no guidance is removed. Validator green (was the blocker), markdownlint green.

Follow-through once merged: the project-local memory feedback_read_the_issue_list_before_filing.md in the nr-llm session memory gets re-homed to point here (promote-then-tombstone).

Assisted by claude-code:claude-opus-5 — Session

Every rule in this reference exists because skipping it produced a public
artifact that had to be walked back, all in one upstream engagement
(FriendsOfTYPO3/fractor, 2026-08-25):

- Three keyword searches came back empty against a repo whose open issue
  described the same defect in different words, with the fix already in an
  open PR — the repo had six open issues, and reading the list would have
  taken a minute. Duplicate issue and PR both had to be closed. Hence: read
  the open issue AND PR lists; an empty search is first a broken query.
- Two five-line comment blocks were the longest in the entire codebase until
  a reviewer asked why. Hence: measure comment density, do not import house
  style.
- The PR went out non-draft and a documented contributing step (composer
  docs) was skipped. Hence: draft-first, run ALL of the contract.
- The project's own rectify fixers rewrote four unrelated files during the
  gate run. Hence: revert what the fixer touched that you did not.
- What ended the thread well: running the maintainer's competing fix against
  the own reproduction and answering with measured numbers, then closing the
  superseded PR in its favour. Hence the last two sections.

SKILL.md gains a When-to-Use trigger and the reference row. main sat at 499
words of the 500-word cap, so existing prose is compressed to make room:
"See X (a, b)" becomes "X: a, b", two headings lose filler words, one
redundant reference parenthetical goes (the table row carries it), and one
code comment drops context the neighbouring bullet already states. No
guidance is removed.

Assisted-by: claude-code:claude-opus-5
Agent-Session: https://claude.ai/code/session_01GSptxPLHWsttu9FuqVkvYZ
Agent-Host: 0493f0
Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>
Copilot AI lite review requested due to automatic review settings August 25, 2026 21:36
@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions github-actions Bot added documentation Improvements or additions to documentation skill labels Aug 25, 2026
@sonarqubecloud

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@CybotTM

CybotTM commented Aug 25, 2026

Copy link
Copy Markdown
Member Author

Copilot review is unavailable — account-wide monthly quota. Reviewed the diff myself; what I checked beyond reading it:

  • The word-cap compressions are lossless. main sat at 499 of the 500-word cap, so adding the reference row and trigger required trimming existing prose. Each trim is listed in the commit message; I re-read every compressed line against its original — no pointer and no rule disappeared (the one removed parenthetical reference is carried by the table row that already listed it).
  • The validator that rejected the first commit passes now (Validate skill repo structure: Passed, 498 words), and markdownlint-cli2 is clean on both files — the same two gates CI runs.
  • The reference's claims are session-verified, not invented: every rule cites the concrete failure it comes from, and the two shell snippets in it were run, not sketched.

What this cannot do: a reference only helps if it is read before the first artifact goes out — that is why the When-to-Use trigger exists, and it is the part I would most want a human eye on: is the trigger phrasing findable enough?

Assisted by claude-code:claude-opus-5 — Session

@CybotTM

CybotTM commented Aug 25, 2026

Copy link
Copy Markdown
Member Author

Self-review: 839286d

The review this pull request demands is unsatisfiable (Copilot quota wall or repeated bot failures on this head). Per the documented fallback, the diff on this head was reviewed by the PR author; this comment is the on-the-record attestation the merge gate reads back. It stops matching on the next push.

@CybotTM
CybotTM merged commit 9610335 into main Aug 25, 2026
20 of 21 checks passed
@CybotTM
CybotTM deleted the feat/upstream-contributions branch August 25, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation skill

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants