docs(references): worktree path resolution, unpiped gates, thread pagination#91
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds documentation on bare-repo layouts and relative path resolution, warns about the risks of piping commands whose exit codes gate subsequent steps, and details how to handle pagination when querying many review threads via the GitHub GraphQL API. The review feedback suggests avoiding the use of grep for error words to gate workflows (recommending gating on the actual exit code instead) and corrects a minor typo ("worktree tree") in the bare-repo documentation.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Add guidance for handling PRs with >100 review threads (common with automated reviewers like Copilot, Entelligence). GitHub GraphQL API has 100-item limit per page. Learned from PR #575 which had 127 review threads. Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
- advanced-git: with git -C .bare, a relative worktree path resolves from inside .bare - ../<branch> or an absolute path; check for a pre-existing plain clone before nesting a .bare (two mis-placed worktrees in one session) - pull-request-workflow: generalize the piped-push trap to every gating command - a verification docker build piped through tail reported the pipe's rc and a red build was pushed as 'OK'; log-file + $? pattern Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
CybotTM
force-pushed
the
retro/nrs-4496-worktree-paths-unpiped-gates
branch
from
0538858 to
b622a00
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the Git workflow reference docs with guidance learned from a retro: avoiding worktree misplacement in bare-repo layouts, preventing false “success” when gating commands are piped, and documenting GraphQL pagination for large numbers of PR review threads.
Changes:
- Adds guidance on avoiding piped “gating” commands that can mask failures due to pipeline exit-code behavior.
- Adds a new section on handling >100 GitHub PR review threads via GraphQL pagination.
- Documents path-resolution pitfalls when adding worktrees from a
.barerepo layout.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| skills/git-workflow/references/pull-request-workflow.md | Adds guidance on unpiped gating commands and introduces a pagination section for large review-thread counts. |
| skills/git-workflow/references/advanced-git.md | Adds a note about git -C .bare worktree add relative-path resolution in bare-repo layouts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- pipeline-status wording: last command's rc unless pipefail; trailing grep fails green builds even with pipefail - gate snippet: gate on the command's own rc, log inspection non-fatal - worktree section: replaced with pointer to the existing bare-repo path-resolution section plus the unique plain-clone-mixing warning (also removes the 'worktree tree' typo) - pagination: one page per call, loop on endCursor - no ALL-threads overpromise Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
|
Three additions from a retro of the NRS-4496 session:
git -C .bare worktree add <relative>resolves from inside.bare; two worktrees landed in the wrong place in one session (./xinside.bare/,../<project>/xnested a level deep). Documents the../<branch>/absolute-path rule and the plain-clone-vs-.bare mixing check.docker build … | tail -2 && echo OKprinted OK for a failed build, and the red branch was pushed. Log-file +$?pattern.reviewThreadspagination for 100+ threads, PR #575 lesson) was stranded on a stale branch; rebased onto current main and included here.