Only process latest valid packet for better sync #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I first made this change in WLED‑MM because I noticed that sometimes multiple audio sync packets would pile up in the buffer. That caused the LEDs to react a little behind the live audio, since older packets were being processed instead of the newest one.
On the ESP32‑P4, with its larger network buffers (or my enabling of larger buffer sizes), this buffering effect probably became more obvious, which is why switching to only decode the latest packet made such a difference.
In a real-time system, the latest packet is the right one - and working thru the backlog seems like the wrong thing to do.
I fixed this in MoonLight as well (leading to this patch) as it was very laggy until I made the change I'd done for WLED-MM.