Conversation
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (7)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: 9 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour. 📝 SummarySummary by CodeRabbit
WalkthroughAdded an optional Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~15 minutes Change: Feature Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
The commands opened every store without a region, so they could only ever read the default one, with no way to target a store whose data is held elsewhere. The API path already honours the region, so this passes the flag through to `getStore`. Omitting the flag sends no region at all, exactly as before. Needs `region` on `GetStoreOptions`, which @netlify/blobs 11.1.0 added and main already depends on.
bb15611 to
c888f27
Compare
📊 Benchmark resultsComparing with 1e2da46
|
commit: |
Generated by `npm run docs`, which the verify-docs check regenerates and compares.
Regenerated on the Node version CI pins. `sortOptions` returns -1 whenever either side is a base flag, so the order it produces depends on the sort implementation and differs between Node versions.
The
blobs:*commands opened every store without a region, so they could only ever read the default one. There was no way to target a store whose data is held in another region, which meant the CLI could not be used to confirm where data actually is.The API path already honours the region, so this adds a
--regionflag to the four commands and passes it through togetStore. An unsupported value is rejected by the client with the list of supported regions.Omitting the flag is unchanged behaviour: no region is sent, and the API picks its default.
Requires
@netlify/blobs11.1.0 (bumped here from 11.0.3) — that release is whereregionbecame an option on site-wide stores, so the flag does not type-check without it.