build: switch from prettier to 11x faster oxfmt 🚀 - #8382
Open
serhalp wants to merge 3 commits into
Open
Conversation
Contributor
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe repository adopts Oxfmt and removes Prettier formatting configuration and dependency usage. Documentation, configuration, source, site, fixtures, tests, and TypeScript declarations are reformatted. Several nullish-coalescing fallback expressions receive explicit grouping, and clone error formatting is adjusted. Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
serhalp
commented
Jul 31, 2026
| configPath?: string | ||
| siteId?: string | ||
| get id(): string | undefined | ||
| set id(id: string): void |
Member
Author
There was a problem hiding this comment.
This was invalid TypeScript, obscured by skipLibCheck: true but caught by oxfmt's parser.
serhalp
commented
Jul 31, 2026
| // This module is "TypeScript" but contains no actual type annotations, so | ||
| // the resulting `.d.ts` file is just useless `any`s. | ||
| declare module 'lambda-local' { | ||
| declare interface Options { |
Member
Author
There was a problem hiding this comment.
This was invalid TypeScript, obscured by skipLibCheck: true but caught by oxfmt's parser.
- `prettier --check`: 3413 ms median over 5 runs - `oxfmt --check`: 304 ms median over 5 runs Instead of porting over our exact prettier globs, this also starts formatting all oxfmt default globs, including json, toml, markdown, etc.
serhalp
commented
Jul 31, 2026
| "printWidth": 120, | ||
| "proseWrap": "always", | ||
| "trailingComma": "all", | ||
| "sortPackageJson": false, |
Member
Author
There was a problem hiding this comment.
We could turn this one later 😁. I didn't wanna touch too many things here.
serhalp
commented
Jul 31, 2026
Comment on lines
+3
to
+7
| "semi": false, | ||
| "singleQuote": true, | ||
| "printWidth": 120, | ||
| "proseWrap": "always", | ||
| "trailingComma": "all", |
Member
Author
There was a problem hiding this comment.
Would be nice to just use defaults, but this matches our Netlify code style
serhalp
force-pushed
the
serhalp/build/oxfmt
branch
from
July 31, 2026 19:26
5f5564a to
bf51b9d
Compare
serhalp
marked this pull request as ready for review
July 31, 2026 19:26
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/PULL_REQUEST_TEMPLATE.md:
- Around line 15-17: Update the checklist text in the pull request template to
use the apostrophes in “you're” and “that's” instead of escaped backticks, and
hyphenate “incident-related.”
In `@tests/integration/__fixtures__/next-app/app/globals.css`:
- Around line 4-6: Update the --font-mono declaration to satisfy Stylelint’s
value-keyword-case rule by lowercasing the unquoted Menlo and Monaco family
names; preserve the existing font fallback order and values.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0160b946-8078-4bc2-b9c1-9b1dbf7d57d6
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (48)
.github/.kodiak.toml.github/PULL_REQUEST_TEMPLATE.md.oxfmtrc.json.prettierignore.prettierrc.jsonCLAUDE.mdCODE_OF_CONDUCT.mdCONTRIBUTING.mdbin/run.jsfunctions-templates/typescript/scheduled-function/{{name}}.mtslayout.htmlpackage.jsonrenovate.json5site/netlify.tomlsite/netlify/functions/error-reporting.tssite/scripts/util/generate-command-data.jssite/src/content.config.tssite/src/fonts/font-face.csssite/src/styles/custom.csssrc/commands/clone/clone.tssrc/commands/types.d.tssrc/lib/api.tssrc/utils/deploy/hash-fns.tssrc/utils/get-repo-data.tssrc/utils/live-tunnel.tssrc/utils/shell.tstests/integration/__fixtures__/dev-server-with-header-matching-edge-functions/netlify.tomltests/integration/__fixtures__/dev-server-with-header-matching-edge-functions/public/index.htmltests/integration/__fixtures__/hugo-site/layouts/_default/list.htmltests/integration/__fixtures__/next-app-without-config/app/globals.csstests/integration/__fixtures__/next-app-without-config/app/page.module.csstests/integration/__fixtures__/next-app/app/globals.csstests/integration/__fixtures__/next-app/app/page.module.csstests/integration/__fixtures__/plugin-changing-publish-dir/netlify.tomltests/integration/commands/dev/redirects.test.tstests/integration/commands/env/env-get.test.tstests/integration/commands/env/env-list.test.tstests/integration/commands/env/env-set.test.tstests/integration/commands/functions-invoke/functions-invoke.test.tstests/unit/commands/database/db-migration-pull.test.tstests/unit/commands/database/db-migrations-reset.test.tstests/unit/commands/database/db-status.test.tstests/unit/commands/database/util/api-errors.test.tstypes/ascii-table/index.d.tstypes/express-logging/index.d.tstypes/lambda-local/index.d.tstypes/maxstache-stream/index.d.tstypes/maxstache/index.d.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
netlify/blueprints(manual)
💤 Files with no reviewable changes (2)
- .prettierrc.json
- .prettierignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves this repo's build tooling from prettier to oxfmt. This results in an ~11x speedup of formatting.
On my Apple M3 Pro:
prettier --check: 3413 ms median over 5 runsoxfmt --check: 304 ms median over 5 runsInstead of porting over our exact prettier globs, this also starts formatting all oxfmt default globs, including json, toml, markdown, etc. That accounts for much of the diff in this PR.