Skip to content

Update documentation and Nedi diagrams to Mermaid 12 - #3093

Open
ktsaou wants to merge 1 commit into
masterfrom
update-nedi-browser-deps-sow187
Open

ktsaou wants to merge 1 commit into
masterfrom
update-nedi-browser-deps-sow187

Conversation

@ktsaou

@ktsaou ktsaou commented Sep 17, 2026

Copy link
Copy Markdown
Member

Summary

Use Mermaid 12.0.0 for both documentation diagrams and Nedi, with the version 12 rendering defaults. Update Nedi Markdown-it to 15.0.2 and Viz.js to 3.30.0, including matching CDN integrity hashes.

Chevrotain pins vulnerable lodash-es 4.17.23. A qualified resolution selects 4.18.1 for the local bundle; README documents the exact-pin exception. The immutable Nedi CDN was inspected separately: the implementations affected by GHSA-r5fr-rjxr-66jc and GHSA-f23m-r3pf-42rh are absent from its source map. The local resolution does not modify CDN bytes.

Validation

  • Frozen Yarn installation and production build passed.
  • Supported Node 22: 478 Vitest tests passed, one skipped; 73 Node tests passed.
  • Built Registry and Parents pages rendered six diagrams across light/dark modes without browser exceptions.
  • Baseline/candidate audits have identical 168 advisory/path pairs; no introduced findings and no Mermaid/lodash-es findings.
  • Old/new Nedi producer and consumer combinations passed browser rendering checks.

The Viz.js update overlaps #3073. This PR includes that asset change but does not change the other PR's status.


Summary by cubic

Updates documentation and Nedi diagrams to Mermaid 12.0.0 with its new rendering defaults, and bumps @viz-js/viz to 3.30.0 and Nedi's markdown-it to 15.0.2 (with updated CDN integrity hashes). Adds a resolution for lodash-es 4.18.1 to address a vulnerability in Chevrotain (pinned by Mermaid) that only affects the local documentation bundle; the Nedi CDN assets are unaffected.

Written for commit e95c436. Summary will update on new commits.

Review in cubic

@netlify

netlify Bot commented Sep 17, 2026

Copy link
Copy Markdown

Deploy Preview for netdata-docusaurus ready!

Name Link
🔨 Latest commit e95c436
🔍 Latest deploy log https://app.netlify.com/projects/netdata-docusaurus/deploys/6aab78b5f2f5fe000771a220
😎 Deploy Preview https://deploy-preview-3093--netdata-docusaurus.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 8 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: dd7b2865-bd02-4978-b13e-2e6adb3efbef

📥 Commits

Reviewing files that changed from the base of the PR and between 1717211 and e95c436.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (4)
  • README.md
  • package.json
  • src/components/Nedi/assets.js
  • tests/dependency_authority.test.js

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant