Conversation
✅ Deploy Preview for netdata-docusaurus ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Warning Review limit reachedNext included review available in 8 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use Mermaid 12.0.0 for both documentation diagrams and Nedi, with the version 12 rendering defaults. Update Nedi Markdown-it to 15.0.2 and Viz.js to 3.30.0, including matching CDN integrity hashes.
Chevrotain pins vulnerable lodash-es 4.17.23. A qualified resolution selects 4.18.1 for the local bundle; README documents the exact-pin exception. The immutable Nedi CDN was inspected separately: the implementations affected by GHSA-r5fr-rjxr-66jc and GHSA-f23m-r3pf-42rh are absent from its source map. The local resolution does not modify CDN bytes.
Validation
The Viz.js update overlaps #3073. This PR includes that asset change but does not change the other PR's status.
Summary by cubic
Updates documentation and Nedi diagrams to Mermaid 12.0.0 with its new rendering defaults, and bumps
@viz-js/vizto 3.30.0 and Nedi'smarkdown-itto 15.0.2 (with updated CDN integrity hashes). Adds a resolution forlodash-es4.18.1 to address a vulnerability in Chevrotain (pinned by Mermaid) that only affects the local documentation bundle; the Nedi CDN assets are unaffected.Written for commit e95c436. Summary will update on new commits.